Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase golang ci lint timeout to 5 minutes #2702

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

bobbypage
Copy link
Collaborator

@bobbypage bobbypage commented Oct 28, 2020

Some of the CI linters appear to be timing out, e.g. on #2697

2020-10-28T21:26:44.8348743Z >> running golangci-lint using configuration at .golangci.yml
2020-10-28T21:27:45.0836302Z level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
2020-10-28T21:27:45.0960089Z ##[error]make: *** [Makefile:99: lint] Error 4
2020-10-28T21:27:45.0966521Z ##[error]Process completed with exit code 2.

Default timeout appears to be 1m, so bumping to 5 minutes to avoid golangci-lint from timing out

@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@bobbypage bobbypage merged commit 771d518 into google:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants