fix(subplanners): Match aliased dependencies by name and semver

[Arm1stice]

This PR adds an additional check to ensure that a dependency with an alias is matched by both name and it's version compared to the required semver in the dependency metadata. This allows a situation in which a crate has a dependency listed multiple times with different versions, some with aliases and others without.

Fixes #345

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[Arm1stice]

@googlebot I signed it!

Must have triggered since I'm not currently an employee 😅

[UebelAndre]

Hey! Glad to see you're around and still making contributions. Do you think you can find a smaller crate that demonstrates this behavior? I was the author of these template files and before I started on #300 I was only dealing with small sets of metadata until I ran into test_plan_build_produces_aliased_dependencies. Would you also be willing to also update that test to use a smaller example and maybe add some comments kinda explaining what's going on in that test?

[Arm1stice]

Hey! Glad to see you're around and still making contributions. Do you think you can find a smaller crate that demonstrates this behavior? I was the author of these template files and before I started on #300 I was only dealing with small sets of metadata until I ran into test_plan_build_produces_aliased_dependencies. Would you also be willing to also update that test to use a smaller example and maybe add some comments kinda explaining what's going on in that test?

I can definitely try to do this! The biggest issue is that the crate I'm using in the test is the only one that I know of that has this condition. Unless I upload a custom crate to the registry that recreates it. If I do that I can certainly reduce the size of the test.

[Arm1stice]

@UebelAndre Tests should be fixed now, let me know if you think there is more room for improvement

[UebelAndre]

@UebelAndre Tests should be fixed now, let me know if you think there is more room for improvement

This looks MUCH better, thank you so much!!!

@GregBowyer started working on a way to fix various aliasing bugs in #282 so they might be interested in this as well. Other than that, @acmcarther will have to also review this before it's merged.

But again, thank you! Very excited to finally understand what that test does and I think cargo-raze-alias-test is pretty awesome 😄

[acmcarther]

LGTM

[UebelAndre]

@Arm1stice can you link the source code to cargo-raze-alias-test here? I think we should add it to this repo so we can expand upon it for various aliasing examples.

[UebelAndre]

re #346 (comment)
@Arm1stice Hey, just pinging this again 😅

[Arm1stice]

re #346 (comment)
@Arm1stice Hey, just pinging this again 😅

Sorry, missed this. I have published at https://github.com/Arm1stice/cargo-raze-alias-test