Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull @rules_rust in cargo_raze_repositories(). #396

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

PiotrSikora
Copy link
Contributor

Signed-off-by: Piotr Sikora [email protected]

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Signed-off-by: Piotr Sikora <[email protected]>
@PiotrSikora PiotrSikora marked this pull request as ready for review March 6, 2021 23:17
@PiotrSikora PiotrSikora requested a review from acmcarther as a code owner March 6, 2021 23:17
@PiotrSikora
Copy link
Contributor Author

cc @UebelAndre

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for fixing that 😀

@UebelAndre
Copy link
Collaborator

Oh, actually, I'm not sure if the call to rust_repositories should be in that file. Users may not want to call that and instead setup toolchains themselves using rust_repository_set directly or something.

@PiotrSikora
Copy link
Contributor Author

Oh, actually, I'm not sure if the call to rust_repositories should be in that file. Users may not want to call that and instead setup toolchains themselves using rust_repository_set directly or something.

rules_repositories() configures a few default rust_repository_set(), but it doesn't prevent people from adding more on their own, so I don't believe it breaks any real use cases.

@UebelAndre
Copy link
Collaborator

That sounds right to me. Then I think this change is good. Thanks again!

@acmcarther
Copy link
Member

LGTM

@acmcarther acmcarther merged commit 272f80b into google:main Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants