Bump dep on semver to 1.0.0 #427
Conversation
illicitonion
force-pushed
the
semver-1
branch
3 times, most recently
from
203f065 to
c3b1a3b
Compare
|
@illicitonion sorry for the delay on that, but #425 has been merged. |
illicitonion
force-pushed
the
semver-1
branch
2 times, most recently
from
07818b7 to
9611ed9
Compare
impl/src/metadata.rs
Outdated
| if self.metadata_template.is_none() { | ||
| return None; | ||
| } | ||
| self.metadata_template.as_ref()?; |
There was a problem hiding this comment.
Can you store this to a value and use it later on line 532? That'll remove both the unwrap in those lines, and make the intent of this more clear.
There was a problem hiding this comment.
Looks like it's breaking the bazel build of this by not having serde-derive as a proc macro dependency? I'm not super familiar with the bazel build for this, but does something need to be regenerated? @UebelAndre, not sure if you'd see an obvious thing right away here.
Overall, looks good to me, though.
|
Yes, if the dependencies are updated, then Then commit the results and things should be good. PS: @dfreese Can you check slack? |
|
Yay, rebasing past #441 fixed CI :) |
No description provided.