Helper DeclareContextProto to extend CEL environment #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hickford
force-pushed
the
declare-context-proto
branch
from
9dfa0b7 to
0d6d873
Compare
|
@TristonianJones Here's the review discussed elsewhere |
|
/gcbrun |
hickford
force-pushed
the
declare-context-proto
branch
2 times, most recently
from
f12979e to
72baebc
Compare
|
Thanks for your comments. Ready for review again. |
|
/gcbrun |
hickford
force-pushed
the
declare-context-proto
branch
from
72baebc to
abbf264
Compare
|
Thanks again, ready. |
…s from the given context proto. Each field of the proto defines a variable of the same name in the environment (https://github.com/google/cel-spec/blob/master/doc/langdef.md#evaluation-environment). TESTED=bazel build ... && bazel test ...
hickford
force-pushed
the
declare-context-proto
branch
from
abbf264 to
97c5bc4
Compare
|
/gcbrun |
TristonianJones
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper DeclareContextProto to extend CEL environment with declarations from the given context proto. Each field of the proto defines a variable of the same name in the environment (https://github.com/google/cel-spec/blob/master/doc/langdef.md#evaluation-environment).
TESTED=bazel test ...