Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTFE Extra Data Issuance Chain Deduplication #1477

Merged
merged 55 commits into from
May 22, 2024
Merged

CTFE Extra Data Issuance Chain Deduplication #1477

merged 55 commits into from
May 22, 2024

Conversation

roger2hk
Copy link
Contributor

This CTFE extra data issuance chain deduplication contributes to #691.

Checklist

@roger2hk roger2hk requested a review from a team as a code owner May 12, 2024 23:55
@roger2hk
Copy link
Contributor Author

MySQL integration to be added into the Cloud Build integration test.

roger2hk
roger2hk commented May 13, 2024
View reviewed changes
trillian/ctfe/handlers.go Outdated Show resolved Hide resolved
phbnf
phbnf reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@phbnf phbnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of reviews on code structure flags. I'm interested to know what others think about this as well. I'll have another look looking closer at the processing of chains itself.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
trillian/ctfe/cache/cache.go Outdated Show resolved Hide resolved
trillian/ctfe/handlers.go Outdated Show resolved Hide resolved
trillian/ctfe/handlers.go Outdated Show resolved Hide resolved
trillian/ctfe/instance.go Outdated Show resolved Hide resolved
trillian/ctfe/instance.go Outdated Show resolved Hide resolved
trillian/ctfe/services.go Outdated Show resolved Hide resolved
trillian/util/log_leaf.go Show resolved Hide resolved
@roger2hk roger2hk requested a review from phbnf May 14, 2024 21:51
mhutchinson
mhutchinson reviewed May 15, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
trillian/ctfe/cache/cache.go Outdated Show resolved Hide resolved
trillian/ctfe/handlers.go Outdated Show resolved Hide resolved
trillian/ctfe/services.go Show resolved Hide resolved
phbnf
phbnf reviewed May 16, 2024
View reviewed changes
trillian/ctfe/handlers.go Outdated Show resolved Hide resolved
mhutchinson
mhutchinson approved these changes May 20, 2024
View reviewed changes
trillian/ctfe/instance.go Outdated Show resolved Hide resolved
trillian/ctfe/services.go Outdated Show resolved Hide resolved
AlCutter
AlCutter approved these changes May 20, 2024
View reviewed changes
trillian/util/log_leaf.go Outdated Show resolved Hide resolved
trillian/ctfe/services.go Show resolved Hide resolved
trillian/ctfe/cache/cache.go Show resolved Hide resolved
phbnf
phbnf reviewed May 21, 2024
View reviewed changes
trillian/util/log_leaf.go Outdated Show resolved Hide resolved
trillian/util/log_leaf.go Outdated Show resolved Hide resolved
trillian/util/log_leaf.go Show resolved Hide resolved
trillian/ctfe/services.go Outdated Show resolved Hide resolved
trillian/ctfe/services.go Show resolved Hide resolved
@roger2hk roger2hk merged commit a3fb01e into google:master May 22, 2024
6 checks passed
@roger2hk roger2hk deleted the extra-data-issuance-chain branch May 22, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCutter AlCutter AlCutter approved these changes

@phbnf phbnf phbnf approved these changes

@mhutchinson mhutchinson mhutchinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roger2hk @mhutchinson @phbnf @AlCutter