Allow requests for consistency proofs where first=second #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These requests don't really make sense but this is for better compatibility with C++ logs, which return an empty proof. Needs log backend change in other repo.
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 68.38% 68.38%
=======================================
Files 54 54
Lines 6620 6620
=======================================
Hits 4527 4527
Misses 1576 1576
Partials 517 517
Continue to review full report at Codecov.
|
daviddrysdale
approved these changes
Sep 7, 2017
AlCutter
reviewed
Sep 7, 2017
| @@ -875,7 +875,7 @@ func parseGetSTHConsistencyRange(r *http.Request) (int64, int64, error) { | |||
| if first < 0 || second < 0 { | |||
| return 0, 0, fmt.Errorf("first and second params cannot be <0: %d %d", first, second) | |||
| } | |||
| if second <= first { | |||
| if second < first { | |||
| return 0, 0, fmt.Errorf("invalid first, second params: %d %d", first, second) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Did you consider just returning an empty proof in here and short-circuiting the RPC?
There was a problem hiding this comment.
I did but we then can't validate that the parameters are inside the valid tree size range.
There was a problem hiding this comment.
Though actually doesn't it cache STHs now? Perhaps we can.
steurer
pushed a commit
to steurer/certificate-transparency-go
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These requests don't really make sense but this is for better compatibility with C++ logs, which return an empty proof for this case. Needs log backend change in other repo:
google/trillian#819