Revisit vars after splitting when processing CommonJS Modules #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this patch and fixes my previously failing tests 👍 |
… split var declarations and then re-visit all the new nodes.
ChadKillingsworth
force-pushed
the
commonjs-split-vars
branch
from
8c6eb89 to
c1ef2d9
Compare
|
LGTM. I'll submit this internally. |
|
FYI, this broke an internal project and was rolled back. I'll try to fix it and roll it forward tomorrow. |
dimvar
pushed a commit
that referenced
this pull request
Aug 3, 2017
*** Original change description *** Because ProcessCommonJSModules has a post-order traversal, we have to split var declarations and then re-visit all the new nodes. Closes #2596 *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164151398
|
The fix was to avoid splitting a VAR inside a FOR header. Hope to roll this forward and push externally today. |
dimvar
added a commit
that referenced
this pull request
Aug 4, 2017
Fix: Back-off the VAR split if the parent is a FOR. *** Original change description *** Because ProcessCommonJSModules has a post-order traversal, we have to split var declarations and then re-visit all the new nodes. Closes #2596 *** ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=164281163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2593
Because rewriting commonjs modules is a post-order traversal, we need to specifically revisit vars after splitting multiple declarations apart.