Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Added --allow-duplicate-declarations flag #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amralassal
Copy link

Allow multiple declarations of css definitions, so there is no need to use alternate flag.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@amralassal
Copy link
Author

I signed it

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@@ -324,10 +327,20 @@ public JobDescriptionBuilder setAllowUnrecognizedFunctions(boolean allow) {
return this;
}

public JobDescriptionBuilder setAllowDuplicateDeclarations(boolean allow) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should go just before allowDuplicateDeclarations. Somehow allowUnrecognizedFunctions managed to slip between the two.

@iflan
Copy link
Member

iflan commented Jan 19, 2016

Besides the comments above (and the problem with the CLA), this looks fine to me. If you need to send a new pull request with the changed commit user, just close this one out.

Thanks!

Ian

@BradMclain
Copy link

Any progress on getting this addition merged?

@iflan
Copy link
Member

iflan commented Mar 16, 2016

There's a problem with the commit authorship. I believe this is because the commits were made with one email address, but the github PR was made with another. When @amralassal either signs the CLA with both or re-writes the commits using the same one as the PR, then we're good to go.

There are also a few minor formatting comments that I'd like addressed as well.

@BradMclain
Copy link

Mind if I take over if @amralassal doesn't respond soon? I would like this feature ASAP :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants