Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use v1 tag for docker images. #2

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Use v1 tag for docker images. #2

merged 1 commit into from
Sep 27, 2021

Conversation

oliverchang
Copy link
Collaborator

No description provided.

jonathanmetzman
jonathanmetzman reviewed Sep 17, 2021
View reviewed changes
Copy link
Collaborator

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused what this will do. Keep in mind we don't want to pull build-fuzzers and run-fuzzers from prebuilt images, we want to build them in github actions to make debugging possible.
I was even thinking of getting rid of the two images and just using one. WDYT of that?

@oliverchang
Copy link
Collaborator Author

I'm confused what this will do. Keep in mind we don't want to pull build-fuzzers and run-fuzzers from prebuilt images, we want to build them in github actions to make debugging possible.
I was even thinking of getting rid of the two images and just using one. WDYT of that?

This makes it much easier to depend on the OSS-Fuzz code, without us having to check it out and build it.

For debugging, we can have still have our own debug-only actions, which can just live in the OSS-Fuzz repo.

Getting rid of two images and using just one SGTM, and seems like a separate issue to this one.

@jonathanmetzman
Copy link
Collaborator

LGTM

@oliverchang oliverchang merged commit e0de7ad into main Sep 27, 2021
@oliverchang oliverchang deleted the use-tag branch October 11, 2021 04:07
evverx added a commit to evverx/clusterfuzzlite that referenced this pull request Apr 22, 2022
@evverx
Switch to the latest images
955f709 
CFLite can't be pinned properly so to unpin it it should be
possible to always use the latest images.

This reverts google#2

Closes google#95
@evverx evverx mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanmetzman jonathanmetzman jonathanmetzman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverchang @jonathanmetzman