Add support for right-to-left languages #1165
Conversation
This updates our `mdbook` version to the latest version in Git. I copied the `index.hbs` file from that version and back-ported our changes into it. I checked English and Danish locally and they both look fine. The new version has support for right-to-left languages: rust-lang/mdBook#1641. We have an in-progress Persian translation. Download the `fa.zip` artifact after building the PR to check how it looks. I checked Persian locally and it looks mirrored like I expect (but we will need someone who can read Persian to actually verify this). Fixes #1164.
mgeisler
force-pushed
the
support-right-to-left
branch
from
3384578 to
4e60953
Compare
|
The tests are done. @mbpouri and @DannyRavi, can you please take a look at |
There was a problem hiding this comment.
According to the implementation I had from comprehensive-rust-fa.zip, the RTL result is good, and according to the experience of RTLs on other platforms, when each line of text starts with an LTR letter, an error occurs in the text.
Also, please check rust-lang/mdBook#1164
Thanks @DannyRavi! I think we should merge this then and we'll let you and others figure out any small details in the coming weeks. |
|
@DannyRavi, I've invited you to collaborate on the repository — this should let you add a review on this PR so I can merge it! |
|
This is now published, see: https://google.github.io/comprehensive-rust/fa/ 🚀 |
This updates our `mdbook` version to the latest version in Git. I copied the `index.hbs` file from that version and back-ported our changes into it. I checked English and Danish locally and they both look fine. The new version has support for right-to-left languages: rust-lang/mdBook#1641. We have an in-progress Persian translation. Download the `fa.zip` artifact after building the PR to check how it looks. I checked Persian locally and it looks mirrored like I expect (but we will need someone who can read Persian to actually verify this). Fixes google#1164.
This updates our
mdbookversion to the latest version in Git. I copied theindex.hbsfile from that version and back-ported our changes into it. I checked English and Danish locally and they both look fine.The new version has support for right-to-left languages: rust-lang/mdBook#1641.
We have an in-progress Persian translation. Download the
fa.zipartifact after building the PR to check how it looks. I checked Persian locally and it looks mirrored like I expect (but we will need someone who can read Persian to actually verify this).Fixes #1164.