Update lifetime-elision.md #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the details section, it is suggested to adjust the signature of the nearest function to "lie" about the lifetimes returned to:
fn nearest<'a, 'q'>(points: &'a [Point], query: &'q Point) -> Option<&'q Point> {
to demonstrate the compiler checks lifetimes for validity. However, the syntax for 'q is incorrect and it should instead be
fn nearest<'a, 'q>(points: &'a [Point], query: &'q Point) -> Option<&'q Point> {
djmitche
approved these changes
Feb 8, 2024
mani-chand
pushed a commit
to mani-chand/comprehensive-rust
that referenced
this pull request
Feb 16, 2024
In the details section, it is suggested to adjust the signature of the
nearest function to "lie" about the lifetimes returned to:
fn nearest<'a, 'q'>(points: &'a [Point], query: &'q Point) -> Option<&'q
Point> {
to demonstrate the compiler checks lifetimes for validity. However, the
syntax for 'q is incorrect and it should instead be
fn nearest<'a, 'q>(points: &'a [Point], query: &'q Point) -> Option<&'q
Point> {
mgeisler
reviewed
Feb 20, 2024
| @@ -61,7 +61,7 @@ references in its arguments that requires explicit annotation. | |||
| Try adjusting the signature to "lie" about the lifetimes returned: | |||
|
|
|||
| ```rust,ignore | |||
There was a problem hiding this comment.
We could perhaps take out the ignore part here — and fill the body with a todo!()?
That should have prevented this kind of tiny typo from occurring. Alternatively, we could put the Rust code in a separate file and include just the line needed to demonstrate the point.
Just some food for thought in case @IP1llar has some free time and want to send us more PRs 😄
|
Thanks a lot @IP1llar for fixing this! We have so many pages now that we're super dependent on folks like you to help us fix typos like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the details section, it is suggested to adjust the signature of the nearest function to "lie" about the lifetimes returned to:
fn nearest<'a, 'q'>(points: &'a [Point], query: &'q Point) -> Option<&'q Point> {
to demonstrate the compiler checks lifetimes for validity. However, the syntax for 'q is incorrect and it should instead be
fn nearest<'a, 'q>(points: &'a [Point], query: &'q Point) -> Option<&'q Point> {