-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es: CR2 Day 1 translations #1857
Conversation
Both PRs #1857 and #1858 suffer from the same problems: The review step is showing an error for unintended msgid changes, and 13000 lines removed plus over 1000 lines added. Even via console I don't know really how to review this. It doesn't look like we're changing the translations, instead it seems we're directly replacing the whole translation files. I would kindly ask if this can be made in smaller diffs that are more comprehensive. If not, it will take me several hours to do a review as I'd probably will need to build the whole course and compare manually to the website that it builds instead of the code. Also a quick search of a random old translation shows that it doesn't exist on the new one. I just searched for "Operator Overloading" and seems that it is lost. |
Hi @deavid, thanks for your feedback. |
All reviews done. Thanks for making the diffs easier to manage. |
@deavid Thank you! |
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Spanish content is reviewed.
#1463 #284