-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
es: CR2 Chromium translations #1868
Conversation
@deavid Can you check whether you were logged with your personal email (that can explain the "missing CLA")? |
I am always logged with my personal email. I don't use corp for GitHub. Moreover, all changes and reviews have been done from the same personal computer. There's no difference from my side. I don't see a CLA problem, I see a format problem. One of the suggestions I gave you breaks the formatter. Can you fix? |
I see now that the CLA was failing, my bad. And after my review it is still failing. Strange. @mgeisler do you know how we can debug this? My understanding is that I don't need to sign CLA, and I did not need to sign it for anything before - the other PRs are going smoothly. The only thing I can think of is that there's a commit here that says "co-authored-by" and has my email. Not sure if that is the problem, that maybe Google doesn't store the association on my email but to my GitHub account. If there's need to do, I can sign the CLA, but since I was told that I shouldn't need to do it, I'm holding doing that until we understand if that's the course of action. |
Co-authored-by: David Martínez Martí <[email protected]>
68362ce
to
8e83d1f
Compare
I think this is the problem: it's only |
It was edited by Henri. Told him to delete the Co-Authored or replace it with [email protected] It seems that for some operations GitHub might be adding the email account linked. If it's me who is doing the commits, I can always take care and commit as [email protected], but I can't control from the UI, or what others do. |
Yes, you're spot on... we've seen this before with other Googlers and I don't think there is a better fix than editing the commit like this. |
Professional translations for CR2 content.
Changes are being staged in a separate branch until all Spanish content is reviewed.
#1463 #284