Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es: CR2 Chromium translations #1868

Merged
merged 3 commits into from
Mar 4, 2024
Merged

Conversation

henrif75
Copy link
Collaborator

@henrif75 henrif75 commented Mar 3, 2024

Professional translations for CR2 content.
Changes are being staged in a separate branch until all Spanish content is reviewed.

#1463 #284

@henrif75 henrif75 changed the base branch from main to es-cr2 March 3, 2024 21:52
@henrif75 henrif75 marked this pull request as ready for review March 3, 2024 21:56
@henrif75 henrif75 requested review from deavid and vzz1x2 as code owners March 3, 2024 21:56
po/es.po Outdated Show resolved Hide resolved
po/es.po Outdated Show resolved Hide resolved
po/es.po Outdated Show resolved Hide resolved
po/es.po Outdated Show resolved Hide resolved
@henrif75 henrif75 requested a review from deavid March 4, 2024 02:36
@henrif75
Copy link
Collaborator Author

henrif75 commented Mar 4, 2024

@deavid Can you check whether you were logged with your personal email (that can explain the "missing CLA")?

@deavid
Copy link
Collaborator

deavid commented Mar 4, 2024

@deavid Can you check whether you were logged with your personal email (that can explain the "missing CLA")?

I am always logged with my personal email. I don't use corp for GitHub. Moreover, all changes and reviews have been done from the same personal computer. There's no difference from my side.

I don't see a CLA problem, I see a format problem. One of the suggestions I gave you breaks the formatter. Can you fix?

@deavid
Copy link
Collaborator

deavid commented Mar 4, 2024

I see now that the CLA was failing, my bad. And after my review it is still failing. Strange.

@mgeisler do you know how we can debug this? My understanding is that I don't need to sign CLA, and I did not need to sign it for anything before - the other PRs are going smoothly.

The only thing I can think of is that there's a commit here that says "co-authored-by" and has my email. Not sure if that is the problem, that maybe Google doesn't store the association on my email but to my GitHub account.

If there's need to do, I can sign the CLA, but since I was told that I shouldn't need to do it, I'm holding doing that until we understand if that's the course of action.

henrif75 and others added 2 commits March 4, 2024 15:18
@henrif75 henrif75 merged commit 74992fb into google:es-cr2 Mar 4, 2024
33 checks passed
@henrif75 henrif75 deleted the es-cr2-chromium branch March 4, 2024 23:31
@mgeisler
Copy link
Collaborator

mgeisler commented Mar 7, 2024

@mgeisler do you know how we can debug this? My understanding is that I don't need to sign CLA, and I did not need to sign it for anything before - the other PRs are going smoothly.

The only thing I can think of is that there's a commit here that says "co-authored-by" and has my email. Not sure if that is the problem, that maybe Google doesn't store the association on my email but to my GitHub account.

I think this is the problem: it's only @google.com addresses that are exempt for the CLA check. The check has this link to look further. Right now it says everything is fine, but that's probably because the commit was edited by Henri or you.

@deavid
Copy link
Collaborator

deavid commented Mar 7, 2024

It was edited by Henri. Told him to delete the Co-Authored or replace it with [email protected]

It seems that for some operations GitHub might be adding the email account linked.

If it's me who is doing the commits, I can always take care and commit as [email protected], but I can't control from the UI, or what others do.

@mgeisler
Copy link
Collaborator

mgeisler commented Mar 7, 2024

Yes, you're spot on... we've seen this before with other Googlers and I don't think there is a better fix than editing the commit like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants