Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zh_CN translation #325

Closed
wants to merge 5 commits into from
Closed

Add zh_CN translation #325

wants to merge 5 commits into from

Conversation

hilbert-yaa
Copy link

This is a follow-up of #324.

  • Add machine translation as a starter version
  • Revising the machine translation towards my first draft (overall progress: 25%)
  • Tested serving -> LGTM

@google-cla
Copy link

google-cla bot commented Feb 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mgeisler
Copy link
Collaborator

mgeisler commented Feb 2, 2023

Hi @hilbert-yaa, thanks a lot for putting up the PR!

Since I don't speak Chinese, I'll find someone who does and ask them to read this 😄

@hilbert-yaa
Copy link
Author

Hi @hilbert-yaa, thanks a lot for putting up the PR!

Since I don't speak Chinese, I'll find someone who does and ask them to read this smile

Okay. Note that it's still WIP, and I'll ping you when it's ready for a review. :)

@mgeisler
Copy link
Collaborator

mgeisler commented Feb 3, 2023

Okay. Note that it's still WIP, and I'll ping you when it's ready for a review. :)

Sounds great, thank you very much! I'll put up a language picker in the mean time.

@hilbert-yaa
Copy link
Author

hilbert-yaa commented Feb 7, 2023

We'll be re-working this translation from another starting point, so I'll close this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants