Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

da: Sync translation #714

Merged
merged 3 commits into from
May 30, 2023
Merged

da: Sync translation #714

merged 3 commits into from
May 30, 2023

Conversation

mgeisler
Copy link
Collaborator

This resulted in some rewrapped strings due to how msgmerge wraps the strings compared to how mdbook-xgettext extracts them.

I also translated a few strings.

This resulted in some rewrapped strings due to how `msgmerge` wraps
the strings compared to how `mdbook-xgettext` extracts them.

I also translated a few strings.
@mgeisler mgeisler requested review from voss and thedataking as code owners May 28, 2023 15:41
Copy link
Collaborator

@thedataking thedataking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left a few comments for you to consider.

#: src/exercises/concurrency/chat-app.md:127
#, fuzzy
msgid "## Running the binaries"
msgstr "Afvikling af kurset"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"kurset" vs "binaries" 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, good question! Notice that the translation is marked as "fuzzy": this means that it's a guess made by msgmerge when it updated the file. It tries to reuse the translation from a similar entry — but because it doesn't know if it makes sense, the entry is marked as fuzzy. Fuzzy entries are not used in the actual translation. Someone (probably me) has to go through them and remove the fuzzy marker and fix the actual translation.

@mgeisler mgeisler enabled auto-merge (squash) May 30, 2023 14:30
@mgeisler mgeisler merged commit 6920a47 into main May 30, 2023
@mgeisler mgeisler deleted the da branch May 30, 2023 14:34
NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this pull request Jul 19, 2023
* da: Sync translation

This resulted in some rewrapped strings due to how `msgmerge` wraps
the strings compared to how `mdbook-xgettext` extracts them.

I also translated a few strings.

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants