Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding drift detection without mounting containers #22

Merged
merged 15 commits into from
Dec 11, 2024

Conversation

west-wind
Copy link
Contributor

Adding drift/diff feature emulating this https://kubernetes.io/blog/2023/03/10/forensic-container-analysis/#file-system-changes-rootfs-diff-tar without needing to mount the fs first.

@roshanmaskey
Copy link
Collaborator

Taking a look this week.

@roshanmaskey
Copy link
Collaborator

Overall LGTM. Some minor nits.

It would be great if we can have options to do an individual container as well as all containers.

Example:

/opt/container-explorer/bin/ce  -i /mnt/sdb1 drift CONTAINER_ID
/opt/container-explorer/bin/ce -i /mnt/sdb1 drift-all

Adding support for detecting drift on a specific container
Adding support for detecting drift on a specific container & resolving formatting issues
Adding support for detecting drift on a specific container & resolving formatting issues
Adding support for detecting drift on a specific container
Adding support for detecting drift on a specific container
@west-wind
Copy link
Contributor Author

Overall LGTM. Some minor nits.

It would be great if we can have options to do an individual container as well as all containers.

Example:

/opt/container-explorer/bin/ce  -i /mnt/sdb1 drift CONTAINER_ID
/opt/container-explorer/bin/ce -i /mnt/sdb1 drift-all

@roshanmaskey Adding support for detecting drift on a specific container. If a container ID is provided with drift/diff, then only that specific containers drift is shown. If no container ID is provided, the drift of all containers is shown.

Adjusted indentations.
Adjusted indentations.
@roshanmaskey roshanmaskey merged commit 4d1a0b4 into google:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants