Internal refactoring.

PiperOrigin-RevId: 373634042
google · May 13, 2021 · 62d1bf7 · 62d1bf7
1 parent 5913d86
commit 62d1bf7
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/inlineme/Inliner.java b/core/src/main/java/com/google/errorprone/bugpatterns/inlineme/Inliner.java
@@ -245,13 +245,7 @@ private Description match(
   }
 
   private Description describe(Tree tree, SuggestedFix fix, Api api) {
-    return buildDescription(tree)
-        .setMessage(
-            api.shortName()
-                + " is deprecated and should be inlined"
-            )
-        .addFix(fix)
-        .build();
+    return buildDescription(tree).setMessage(api.deprecationMessage()).addFix(fix).build();
   }
 
   @AutoValue
@@ -271,21 +265,27 @@ static Api create(MethodSymbol method) {
 
     abstract boolean isConstructor();
 
+    final String deprecationMessage() {
+      return shortName()
+          + " is deprecated and should be inlined"
+      ;
+    }
+
     /** Returns {@code FullyQualifiedClassName#methodName}. */
-    String methodId() {
+    final String methodId() {
       return String.format("%s#%s", className(), methodName());
     }
 
     /**
      * Returns a short, human readable description of this API (e.g., {@code
      * ClassName.methodName()}).
      */
-    String shortName() {
+    final String shortName() {
       return String.format("%s.%s()", simpleClassName(), methodName());
     }
 
     /** Returns the simple class name (e.g., {@code ClassName}). */
-    String simpleClassName() {
+    final String simpleClassName() {
       return Iterables.getLast(CLASS_NAME_SPLITTER.split(className()));
     }
   }