Fix some ES2 issues #7359
Merged
Fix some ES2 issues #7359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bejado
approved these changes
Nov 13, 2023
pixelflinger
requested changes
Nov 13, 2023
| @@ -83,11 +83,9 @@ class OpenGLDriver final : public DriverBase { | |||
| } | |||
|
|
|||
| struct { | |||
| GLuint id; | |||
There was a problem hiding this comment.
That's very unfortunate, it'll double the size of this structure for the regular case. I can't think of a better way though.
elizagamedev
force-pushed
the
exv/essl1-fixes
branch
from
2e4fde6 to
52ad03b
Compare
pixelflinger
approved these changes
Nov 14, 2023
Fix specification of mipmaps when generating textures. Fix oversight where emulated UBOs would not replace uniforms when swapped out for another.
elizagamedev
force-pushed
the
exv/essl1-fixes
branch
from
52ad03b to
20e0e12
Compare
|
I made a slight change. I added a fix to depth_main.fs to remove the ESSL 3.0+ specific syntax with ESSL 1.0 compatible syntax which was in #7358 . That PR depends on upstream changes so I agreed with @poweifeng to delay it for now, but this fix is still critical for FL0 to function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix specification of mipmaps when generating textures.
Fix oversight where emulated UBOs would not replace uniforms when swapped out for another.