large code cleanup #8364
Merged
large code cleanup #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pixelflinger
commented
Jan 16, 2025
pixelflinger
commented
- remove redundant qualifiers
- use is_same_v instead of is_same
- bring back Builder::name() for better documentation
- add missing const parameters in implementation files
- various cleanups
|
Please add a release note line to NEW_RELEASE_NOTES.md. If this PR does not warrant a release note, add the 'internal' label to this PR. |
pixelflinger
force-pushed
the
ma/fixit/cleanups
branch
2 times, most recently
from
040a086 to
7ebb809
Compare
poweifeng
approved these changes
Jan 17, 2025
| @@ -147,7 +147,7 @@ static float2 find_cusp(float a, float b) noexcept { | |||
| // L = L0 * (1 - t) + t * L1; | |||
| // C = t * C1; | |||
| // a and b must be normalized so a^2 + b^2 == 1 | |||
| static float find_gamut_intersection(float a, float b, float L1, float C1, float L0) noexcept { | |||
| static float find_gamut_intersection(float const a, float const b, float const L1, float const C1, float const L0) noexcept { | |||
There was a problem hiding this comment.
seems like a really long line.
| return downcast(this)->createSwapChain(nativeWindow, flags); | ||
| } | ||
|
|
||
| SwapChain* Engine::createSwapChain(uint32_t width, uint32_t height, uint64_t flags) noexcept { | ||
| SwapChain* Engine::createSwapChain(uint32_t const width, uint32_t const height, uint64_t const flags) noexcept { |
| return downcast(this)->destroy(e); | ||
| } | ||
|
|
||
| void LightManager::setLightChannel(Instance i, unsigned int channel, bool enable) noexcept { | ||
| void LightManager::setLightChannel(Instance const i, unsigned int const channel, bool const enable) noexcept { |
we keep Builder::name() on all object, and forward to the MixIn class that does the implementation, so that we have correct documentation, and better IDE completion.
- missing includes - missing const - C cast style - superfluous inline keyword
pixelflinger
force-pushed
the
ma/fixit/cleanups
branch
from
7ebb809 to
f0ff137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.