Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle tags now work with heap allocated handles #8370

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Handle tags now work with heap allocated handles #8370

merged 1 commit into from
Jan 22, 2025

Conversation

pixelflinger
Copy link
Collaborator

  • uninlined getHandleTag so that the code is not duplicated when multiple backends are supported (e.g. GLES and Vulkan)
  • added a lock for mDebugTags because, even if rare, it technically can be accessed from multiple threads. This would happen only on a failure. There should never be any contention on this lock.

@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Jan 18, 2025
@pixelflinger pixelflinger requested a review from bejado January 18, 2025 01:49
@pixelflinger pixelflinger force-pushed the ma/fixit/handleallocator branch from 889dfa0 to 8a265e0 Compare January 18, 2025 01:52
@pixelflinger
Handle tags now work with heap allocated handles
354d2e7 
- uninlined getHandleTag so that the code is not duplicated when
  multiple backends are supported (e.g. GLES and Vulkan)
- added a lock for mDebugTags because, even if rare, it technically
  can be accessed from multiple threads. This would happen only
  on a failure. There should never be any contention on this lock.
@pixelflinger pixelflinger force-pushed the ma/fixit/handleallocator branch from 8a265e0 to 354d2e7 Compare January 21, 2025 17:49
@pixelflinger pixelflinger merged commit 2d867a9 into main Jan 22, 2025
13 checks passed
@pixelflinger pixelflinger deleted the ma/fixit/handleallocator branch January 22, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bejado bejado bejado approved these changes

Assignees
No one assigned
Labels
internal Issue/PR does not affect clients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixelflinger @bejado