attempt to fix crashers when initializing the JVM #8380
Merged
+136
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clarify precondition for VirtualMachineEnv, in particular, JNI_OnLoad() must be called from a thread attached to the VM, and should be called once. This is now enforced internally, subsequent calls are ignored. - sVirtualMachine was written and read from potentially different threads without synchronization. It is now mutex protected. - added fatal asserts in all locations that we cannot recover from; previously we would stay in an undefined state. BUGS=[390724273]
pixelflinger
force-pushed
the
ma/jnienv
branch
from
e42f6b7 to
42a5757
Compare
pixelflinger
requested review from
romainguy,
bejado and
z3moon
and removed request for
bejado
romainguy
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clarify precondition for VirtualMachineEnv, in particular, JNI_OnLoad() must be called from a thread attached to the VM, and should be called once. This is now enforced internally, subsequent calls are ignored.
sVirtualMachine was written and read from potentially different threads without synchronization. It is now mutex protected.
added fatal asserts in all locations that we cannot recover from; previously we would stay in an undefined state.
BUGS=[390724273]