add a version of Engine::flushAndWait that takes a timeout #8382
+60
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version that doesn't take a timeout now always waits forever; before it waited for a few seconds on Android debug builds. The new version has an explicit timeout that works on all platforms and returns success status. FIXES=[384043020]
poweifeng
approved these changes
Jan 24, 2025
| // finally, execute callbacks that might have been scheduled | ||
| getDriver().purge(); | ||
|
|
||
| return status == FenceStatus::CONDITION_SATISFIED; |
There was a problem hiding this comment.
I think there's also FenceStatus::ERROR? Here it'll get translated to timeout.
There was a problem hiding this comment.
yeah, the return value is more success/fail -- we'll see how it goes, I didn't want to expose the 3-states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old version that doesn't take a timeout now always waits forever; before it waited for a few seconds on Android debug builds.
The new version has an explicit timeout that works on all platforms and returns success status.
FIXES=[384043020]