-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update grpc version #7535
update grpc version #7535
Conversation
The |
@dbaileychess without the @meteorcloudy for visibility + additional advise. It's worth noting that this is blocking the |
I think the context is: grpc/grpc#29750 |
@aranguyen RC files are meant for local configuration overrides and shouldn't be the default way to enforce common configuration changes. |
@dbaileychess this is the workspace level If this still doesn't work, do you have any other suggestion? |
@dbaileychess I looked around a bit more to see if there is a better alternative. But having this flag in |
@aranguyen I am just worried because that means everyone who builds flatbuffers (with or without grpc) is forced to go to C++14. If its just CI failing, we should use the command-line way to specify the flag. For users who are using grpc, when they get the grpc repo, it should come with that Correct me if I'm wrong. |
I see, flatbuffer only needs grpc for testing: https://github.com/google/flatbuffers/search?q=com_github_grpc_grpc Then indeed it doesn't make sense to force flatbuffer to be built with C++14. The problem here is because grpc added this flag in their bazelrc file, but bazelrc doesn't propagate downstream, so this flag is missing when building grpc as a dependency, and it's broken in grpc 1.49.0. I have suggested to move this flag to some bzl file that defines their common c++ options. grpc/grpc#29750 (comment) In the meantime, we can patch grpc 1.49.0 to make it work. Sent #7538 |
thank you both for the discussion. Since #7538 is sent out, this pr is obsolete...closing. |
update grpc to the latest version to enable the flag flip for
--incompatible_use_platforms_repo_for_constraints
bazelbuild/continuous-integration#1404