Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Update Platforms #8083

Merged
merged 5 commits into from
Sep 20, 2023
Merged

[bazel] Update Platforms #8083

merged 5 commits into from
Sep 20, 2023

Conversation

sgowroji
Copy link
Contributor

Fixes #8082

@sgowroji sgowroji changed the title Update Platforms [bazel] Update Platforms Aug 30, 2023
@sgowroji
Copy link
Contributor Author

@keith Does this require any above changes?

@keith
Copy link
Contributor

keith commented Aug 31, 2023

this LGTM! the CI failed on buildifier, so you'll need to format it

@sgowroji
Copy link
Contributor Author

sgowroji commented Sep 6, 2023

dbaileychess Can you review.

Copy link
Collaborator

@le-michael le-michael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@le-michael le-michael merged commit a6a3989 into google:master Sep 20, 2023
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Update Platforms

* Update WORKSPACE

* indentation

* Update WORKSPACE

---------

Co-authored-by: Michael Le <[email protected]>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Update Platforms

* Update WORKSPACE

* indentation

* Update WORKSPACE

---------

Co-authored-by: Michael Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error no such target '@platforms//os:visionos': target 'visionos' not declared in package 'os' in Bazel CI
3 participants