-
Notifications
You must be signed in to change notification settings - Fork 123
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding provisional support for metadata keys/values in scopes.
RELNOTES=Adding provisional support for metadata keys/values in scopes. PiperOrigin-RevId: 342716796
- Loading branch information
Showing
4 changed files
with
528 additions
and
45 deletions.
There are no files selected for viewing
241 changes: 241 additions & 0 deletions
241
api/src/main/java/com/google/common/flogger/context/ScopeMetadata.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,241 @@ | ||
/* | ||
* Copyright (C) 2020 The Flogger Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.common.flogger.context; | ||
|
||
import static com.google.common.flogger.util.Checks.checkArgument; | ||
import static com.google.common.flogger.util.Checks.checkNotNull; | ||
|
||
import com.google.common.flogger.MetadataKey; | ||
import com.google.common.flogger.backend.Metadata; | ||
import java.util.ArrayList; | ||
import java.util.Arrays; | ||
import java.util.List; | ||
import org.checkerframework.checker.nullness.compatqual.NullableDecl; | ||
|
||
/** | ||
* Immutable {@link Metadata} implementation intended for use in nested scopes. Scope metadata can | ||
* be concatenated to inherit metadata from a parent scope. This class is only expected to be needed | ||
* by implementations of {@link ScopedLoggingContext} and should not be considered a stable API. | ||
*/ | ||
public abstract class ScopeMetadata extends Metadata { | ||
private static final class Entry<T> { | ||
final MetadataKey<T> key; | ||
final T value; | ||
|
||
Entry(MetadataKey<T> key, T value) { | ||
this.key = checkNotNull(key, "key"); | ||
this.value = checkNotNull(value, "value"); | ||
} | ||
} | ||
|
||
/** | ||
* A builder to collect metadata key/values pairs in order. This class is only expected to be | ||
* needed by implementations of {@link ScopedLoggingContext} and should not be considered a stable | ||
* API. | ||
*/ | ||
public static final class Builder { | ||
private static final Entry<?>[] EMPTY_ARRAY = new Entry<?>[0]; | ||
|
||
// Set an explicitly small initial capacity to avoid excessive allocations when we only ever | ||
// expect one or two keys to be added per scope. We don't optimize for the case of zero keys, | ||
// since the scoped context builder shouldn't create a builder until the first key is added. | ||
private final List<Entry<?>> entries = new ArrayList<Entry<?>>(2); | ||
|
||
private Builder() {} | ||
|
||
/** Add a single metadata key/value pair to the builder. */ | ||
public <T> Builder add(MetadataKey<T> key, T value) { | ||
// Entries are immutable and get moved into the metadata when it's built, so these get shared | ||
// and reduce the size of the metadata storage compared to storing adjacent key/value pairs. | ||
entries.add(new Entry<T>(key, value)); | ||
return this; | ||
} | ||
|
||
public ScopeMetadata build() { | ||
// Analysis shows it's quicker to pass an empty array here and let the JVM optimize to avoid | ||
// creating an empty array just to overwrite all its elements. | ||
return new ImmutableScopeMetadata(entries.toArray(EMPTY_ARRAY)); | ||
} | ||
} | ||
|
||
/** Returns a new {@code ScopeMetadata} builder. */ | ||
public static Builder builder() { | ||
return new Builder(); | ||
} | ||
|
||
/** Returns a space efficient {@code ScopeMetadata} containing a single value. */ | ||
public static <T> ScopeMetadata singleton(MetadataKey<T> key, T value) { | ||
return new SingletonMetadata(key, value); | ||
} | ||
|
||
/** Returns the empty {@code ScopeMetadata}. */ | ||
// We can't use empty() here as that's already taken by Metadata. | ||
public static ScopeMetadata none() { | ||
return EmptyMetadata.INSTANCE; | ||
} | ||
|
||
private ScopeMetadata() {} | ||
|
||
/** | ||
* Concatenates the given scope metadata <em>after</em> this instance. Key value pairs are simply | ||
* concatenated (rather than being merged) which may result in multiple single valued keys | ||
* existing in the resulting sequence. | ||
* | ||
* <p>Whether this is achieved via copying or chaining of instances is an implementation detail. | ||
* | ||
* <p>Use {@link com.google.common.flogger.backend.MetadataProcessor MetadataProcessor} to process | ||
* metadata consistently with respect to single valued and repeated keys, and use {@link | ||
* Metadata#findValue(MetadataKey)} to lookup the "most recent" value for a single valued key. | ||
*/ | ||
public abstract ScopeMetadata concatenate(ScopeMetadata metadata); | ||
|
||
// Internal method to deal in entries directly during concatenation. | ||
abstract Entry<?> get(int n); | ||
|
||
@Override | ||
public MetadataKey<?> getKey(int n) { | ||
return get(n).key; | ||
} | ||
|
||
@Override | ||
public Object getValue(int n) { | ||
return get(n).value; | ||
} | ||
|
||
private static final class ImmutableScopeMetadata extends ScopeMetadata { | ||
private final Entry<?>[] entries; | ||
|
||
ImmutableScopeMetadata(Entry<?>[] entries) { | ||
this.entries = entries; | ||
} | ||
|
||
@Override | ||
public int size() { | ||
return entries.length; | ||
} | ||
|
||
@Override | ||
Entry<?> get(int n) { | ||
return entries[n]; | ||
} | ||
|
||
@Override | ||
@NullableDecl | ||
@SuppressWarnings("unchecked") | ||
public <T> T findValue(MetadataKey<T> key) { | ||
checkArgument(!key.canRepeat(), "metadata key must be single valued"); | ||
for (int n = entries.length - 1; n >= 0; n--) { | ||
Entry<?> e = entries[n]; | ||
if (e.key.equals(key)) { | ||
return (T) e.value; | ||
} | ||
} | ||
return null; | ||
} | ||
|
||
@Override | ||
public ScopeMetadata concatenate(ScopeMetadata metadata) { | ||
int extraSize = metadata.size(); | ||
if (extraSize == 0) { | ||
return this; | ||
} | ||
if (entries.length == 0) { | ||
return metadata; | ||
} | ||
Entry<?>[] merged = Arrays.copyOf(entries, entries.length + extraSize); | ||
for (int i = 0; i < extraSize; i++) { | ||
merged[i + entries.length] = metadata.get(i); | ||
} | ||
return new ImmutableScopeMetadata(merged); | ||
} | ||
} | ||
|
||
private static final class SingletonMetadata extends ScopeMetadata { | ||
private final Entry<?> entry; | ||
|
||
<T> SingletonMetadata(MetadataKey<T> key, T value) { | ||
this.entry = new Entry<T>(key, value); | ||
} | ||
|
||
@Override | ||
public int size() { | ||
return 1; | ||
} | ||
|
||
@Override | ||
Entry<?> get(int n) { | ||
if (n == 0) { | ||
return entry; | ||
} | ||
throw new IndexOutOfBoundsException(); | ||
} | ||
|
||
@Override | ||
@NullableDecl | ||
@SuppressWarnings("unchecked") | ||
public <R> R findValue(MetadataKey<R> key) { | ||
checkArgument(!key.canRepeat(), "metadata key must be single valued"); | ||
return entry.key.equals(key) ? (R) entry.value : null; | ||
} | ||
|
||
@Override | ||
public ScopeMetadata concatenate(ScopeMetadata metadata) { | ||
// No check for size() == 0 since this instance always has one value. | ||
int extraSize = metadata.size(); | ||
if (extraSize == 0) { | ||
return this; | ||
} | ||
Entry<?>[] merged = new Entry<?>[extraSize + 1]; | ||
merged[0] = entry; | ||
for (int i = 0; i < extraSize; i++) { | ||
merged[i + 1] = metadata.get(i); | ||
} | ||
return new ImmutableScopeMetadata(merged); | ||
} | ||
} | ||
|
||
// This is a static nested class as opposed to an anonymous class assigned to a constant field in | ||
// order to decouple its classloading when Metadata is loaded. Android users are particularly | ||
// careful about unnecessary class loading, and we've used similar mechanisms in Guava (see | ||
// CharMatchers). | ||
private static final class EmptyMetadata extends ScopeMetadata { | ||
static final ScopeMetadata INSTANCE = new EmptyMetadata(); | ||
|
||
@Override | ||
public int size() { | ||
return 0; | ||
} | ||
|
||
@Override | ||
Entry<?> get(int n) { | ||
throw new IndexOutOfBoundsException(); | ||
} | ||
|
||
@Override | ||
@NullableDecl | ||
public <T> T findValue(MetadataKey<T> key) { | ||
// For consistency, do the same checks as for non-empty instances. | ||
checkArgument(!key.canRepeat(), "metadata key must be single valued"); | ||
return null; | ||
} | ||
|
||
@Override | ||
public ScopeMetadata concatenate(ScopeMetadata metadata) { | ||
return metadata; | ||
} | ||
} | ||
} |
Oops, something went wrong.