-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the macOS example app to use code instead of XIB #10
Comments
This turns out to be non-trivial; I can't find any documentation of what pixel format to pass to the NSOpenGL initializer to match what the IB-constructed version is doing. That's definitely another argument for doing this though, so that it's handled once within the framework's FLEView implementation, rather than each client that doesn't want to use XIBs for the view having to figure it out. |
stuartmorgan
added a commit
that referenced
this issue
Jul 11, 2019
Updates example and testbed for the breaking change in flutter/engine#9741 Removes FLEViewController and FLEView from the XIBs, and instead adds the view controllers in code (which now internally manages the view). Fixes #10
This was referenced Aug 1, 2019
Closed
Closed
This was referenced Sep 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It's hard for someone to inspect a XIB and see what's going on. E.g., it's difficult to tell from the example app right now that double buffering has to be enabled for the view, whereas if we constructed the view and view controller in code it would be obvious, and could be easily commented.
There's a good chance this will involve some fixes to the framework, since the programatic creation of FLEView/FLEViewController hasn't really been used yet, and can almost certainly be made better. Notably -[FLEViewController view] will make a view that won't actually work, since that code path was added as a short-term solution for issues with headless mode.
The text was updated successfully, but these errors were encountered: