Add a clean way to use a custom Flutter engine #160
Assignees
Comments
stuartmorgan
added a commit
that referenced
this issue
Jan 14, 2019
update_flutter_engine and build_flutter_assets now check for an engine_override file at the root of the repository to trigger the use of a local engine. Updates the README to link to instructions on using it. Since this adds more logic to build_flutter_assets, it has been rewritten in Dart. There are some obvious limitations (e.g., hard-coded name/location requirement, copying every time instead of only when the local build has changed), which can be addressed in the future if there's sufficient demand. Since it is only intended for temporary use when debugging, or testing engine changes, this may be sufficient, and is a significant improvement over managing it manually. Unlike .flutter_location_config this has no leading ., and is in the repository rather than above it. This difference is intentional, since unlike .flutter_location_config this is for temporary use, so having it show up in directory listings and git status is helpful as a reminder that it is enabled. Fixes #160
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently the only way to do this is to do a normal build, then replace the library/framework with the locally built version (and remember that your build is no longer actually using the hash that
.last_engine_version, and thus the build output, claims). Updating Flutter will stomp the replacement.And you have to also remember to change
https://github.com/google/flutter-desktop-embedding/blob/master/tools/build_flutter_assets#L26
and undo it when unwinding.
There should be something along the lines of
.flutter_location_configthat bothupdate_flutter_enginecallers andbuild_flutter_assetswill check against that will cause a local build to be copied in and used instead, such that correctly enabling/disabling it is as simple as moving a file. (Or, if we switch to GN, a GN configuration option might work instead.)The text was updated successfully, but these errors were encountered: