Fix travis.sh #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveShuckerow
added a commit
that referenced
this pull request
Nov 8, 2018
Closes #4 PiperOrigin-RevId: 220704036
Merged
DaveShuckerow
added a commit
that referenced
this pull request
Nov 8, 2018
* Initial commit of LinkedScrollController PiperOrigin-RevId: 220688858 * Correct typos in readme.md PiperOrigin-RevId: 220697252 * Fix travis.sh Closes #4 PiperOrigin-RevId: 220704036
jamesderlin
added a commit
that referenced
this pull request
Dec 1, 2018
* Export the linked scroll controller
PiperOrigin-RevId: 220713242
* Add a Flutter VisibilityDetector widget
A VisibilityDetector widget wraps an existing Flutter widget and
fires a callback when the widget's visibility changes. (We actually
report when the visibility of the VisibilityDetector itself
changes, and its visibility is expected to be identical to that of
its child.)
Implementation notes:
* The VisibilityDetector widget's `Key` is required. This is
necessary to associate the VisibilityDetector widget with a
specific RenderObject and Layer. Without a key, layout changes
could trigger unwanted visibility callbacks and report that
VisibilityDetector widgets suddenly became hidden and then
visible again.
* The VisibilityDetector key must be globally unique across all
VisibilityDetector widgets in the app. However, I used a normal
`Key` instead of a `GlobalKey` to avoid forcing clients to use a
specific `Key` implementation. (For example, `UniqueKey` is
globally unique but derives from `LocalKey`.)
* Add a page to the Gallery to demonstrate the `VisibilityDetector`
widget.
* Add widget tests for `VisibilityDetector`. The widget tree is
non-trivial, so instead of duplicating code, make the tests
leverage the Gallery page.
PiperOrigin-RevId: 221373750
PiperOrigin-RevId: 221375140
PiperOrigin-RevId: 221505135
PiperOrigin-RevId: 222451874
PiperOrigin-RevId: 222854998
* Update the pubspec.yaml to publish to pub.
PiperOrigin-RevId: 223190729
jamesderlin
added a commit
that referenced
this pull request
Dec 1, 2018
* Export the linked scroll controller
PiperOrigin-RevId: 220713242
* Add a Flutter VisibilityDetector widget
A VisibilityDetector widget wraps an existing Flutter widget and
fires a callback when the widget's visibility changes. (We actually
report when the visibility of the VisibilityDetector itself
changes, and its visibility is expected to be identical to that of
its child.)
Implementation notes:
* The VisibilityDetector widget's `Key` is required. This is
necessary to associate the VisibilityDetector widget with a
specific RenderObject and Layer. Without a key, layout changes
could trigger unwanted visibility callbacks and report that
VisibilityDetector widgets suddenly became hidden and then
visible again.
* The VisibilityDetector key must be globally unique across all
VisibilityDetector widgets in the app. However, I used a normal
`Key` instead of a `GlobalKey` to avoid forcing clients to use a
specific `Key` implementation. (For example, `UniqueKey` is
globally unique but derives from `LocalKey`.)
* Add a page to the Gallery to demonstrate the `VisibilityDetector`
widget.
* Add widget tests for `VisibilityDetector`. The widget tree is
non-trivial, so instead of duplicating code, make the tests
leverage the Gallery page.
PiperOrigin-RevId: 221373750
PiperOrigin-RevId: 221375140
PiperOrigin-RevId: 221505135
PiperOrigin-RevId: 222451874
PiperOrigin-RevId: 222854998
* Update the pubspec.yaml to publish to pub.
PiperOrigin-RevId: 223190729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.