arefruqaa: v1.002 (#1132) #2476
Conversation
Latest upstream release. Also update metadata and license files.
Fontbakery reportFontbakery version: 0.7.25 [1] Family checks⚠ WARN: Is the command `ftxvalidator` (Apple Font Tool Suite) available?--- Rationale --- There's no reasonable (and legal) way to run the command `ftxvalidator` of the Apple Font Tool Suite on a non-macOS machine. I.e. on GNU+Linux or Windows etc. If Font Bakery is not running on an OSX machine, the machine running Font Bakery could access `ftxvalidator` on OSX, e.g. via ssh or a remote procedure call (rpc). There's an ssh example implementation at: https://github.com/googlefonts/fontbakery/blob/master/prebuilt/workarounds /ftxvalidator/ssh-implementation/ftxvalidator
[8] ArefRuqaa-Bold.ttf🔥 FAIL: Check license file has good copyright string.--- Rationale --- An OFL.txt file's first line should be the font copyright e.g: "Copyright 2019 The Montserrat Project Authors (https://github.com/julietaula/montserrat)"
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb--- Rationale --- The expected pattern for the copyright string adheres to the following rules: * It must say "Copyright" followed by a 4 digit year * Then it must say "The <familyname> Project Authors" * And within parentheses, a URL for a git repository must be provided * The check is case insensitive and does not validate whether the familyname is correct, even though we'd expect it is (and we may soon update the check to validate that aspect as well!) Here is an example of a valid copyright string: "Copyright 2017 The Archivo Black Project Authors (https://github.com/Omnibus-Type/ArchivoBlack)"
🔥 FAIL: Copyright notices match canonical pattern in fonts
🔥 FAIL: Name table strings must not contain the string 'Reserved Font Name'.--- Rationale --- Some designers adopt the "Reserved Font Name" clause of the OFL license. This means that the original author reserves the rights to the family name and other people can only distribute modified versions using a different family name. Google Fonts published updates to the fonts in the collection in order to fix issues and/or implement further improvements to the fonts. It is important to keep the family name so that users of the webfonts can benefit from the updates. Since it would forbid such usage scenario, all families in the GFonts collection are required to not adopt the RFN clause. This check ensures "Reserved Font Name" is not mentioned in the name table.
⚠ WARN: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?--- Rationale --- Traditionally version 0 'gasp' tables were set so that font sizes below 8 ppem had no grid fitting but did have antialiasing. From 9-16 ppem, just grid fitting. And fonts above 17ppem had both antialiasing and grid fitting toggled on. The use of accelerated graphics cards and higher resolution screens make this approach obsolete. Microsoft's DirectWrite pushed this even further with much improved rendering built into the OS and apps. In this scenario it makes sense to simply toggle all 4 flags ON for all font sizes.
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠ WARN: Glyphs are similiar to Google Fonts version?
⚠ WARN: Checking Vertical Metric Linegaps.
[8] ArefRuqaa-Regular.ttf🔥 FAIL: Check license file has good copyright string.--- Rationale --- An OFL.txt file's first line should be the font copyright e.g: "Copyright 2019 The Montserrat Project Authors (https://github.com/julietaula/montserrat)"
🔥 FAIL: Copyright notices match canonical pattern in METADATA.pb--- Rationale --- The expected pattern for the copyright string adheres to the following rules: * It must say "Copyright" followed by a 4 digit year * Then it must say "The <familyname> Project Authors" * And within parentheses, a URL for a git repository must be provided * The check is case insensitive and does not validate whether the familyname is correct, even though we'd expect it is (and we may soon update the check to validate that aspect as well!) Here is an example of a valid copyright string: "Copyright 2017 The Archivo Black Project Authors (https://github.com/Omnibus-Type/ArchivoBlack)"
🔥 FAIL: Copyright notices match canonical pattern in fonts
🔥 FAIL: Name table strings must not contain the string 'Reserved Font Name'.--- Rationale --- Some designers adopt the "Reserved Font Name" clause of the OFL license. This means that the original author reserves the rights to the family name and other people can only distribute modified versions using a different family name. Google Fonts published updates to the fonts in the collection in order to fix issues and/or implement further improvements to the fonts. It is important to keep the family name so that users of the webfonts can benefit from the updates. Since it would forbid such usage scenario, all families in the GFonts collection are required to not adopt the RFN clause. This check ensures "Reserved Font Name" is not mentioned in the name table.
⚠ WARN: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?--- Rationale --- Traditionally version 0 'gasp' tables were set so that font sizes below 8 ppem had no grid fitting but did have antialiasing. From 9-16 ppem, just grid fitting. And fonts above 17ppem had both antialiasing and grid fitting toggled on. The use of accelerated graphics cards and higher resolution screens make this approach obsolete. Microsoft's DirectWrite pushed this even further with much improved rendering built into the OS and apps. In this scenario it makes sense to simply toggle all 4 flags ON for all font sizes.
⚠ WARN: Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠ WARN: Glyphs are similiar to Google Fonts version?
⚠ WARN: Checking Vertical Metric Linegaps.
Summary
Note: The following loglevels were omitted in this report:
Diff images: arefruqaa_qa.zip |
|
Thanks! The spacing for the Latin has changed a lot but it looks way better.
Seems these glyphs are missing
uni06F0, uni06F1, uni06F3, uni06F8, uni06F9 @khaledhosny is this intentional? |
These are fixed in Fontbakery, you might need to update your installation.
This is unfortunate but harmless, it involves the name of the original Latin fonts (EURM10, EURB10) which we don’t use here. |
Yes, that is one of the major changes. It was re-spaced by @kalapi for GF years ago.
Yes, the glyphs are identical to other glyphs so they were de-duplicated and the characters were mapped to the other glyphs:
|
|
SGTM. I'll recheck it once its been pushed to sandbox. |
|
Thanks! |
|
Will be around 2 weeks before it hits prod. Thank you for the clean pr! |
Have there been any progress in this? I still see the old fonts in https://fonts.google.com/specimen/Aref+Ruqaa |
|
Any news? it is been almost two months. Is it stuck somewhere, Amiri is already updated and it was merged later. |
|
@khaledhosny I'll see what's holding it up. If it's good, I'll get it pushed this week. |
|
Friendly reminder. |
|
Sorry for the delay. I'll see what's holding it up. |
|
It is been over three months since this PR was merged and the font is still not updated on the server. cc @davelab6 |
|
Metadata.pb misses arabic in the subset menu, we should add it before sending it to production |
It is been like that since it was first added in #1001, but I can send a PR if you want me to. |
|
it's okay, it's a pretty quick fix, I do it now ;) |
|
Fixed in : #2769 |
|
Thanks! |
No description provided.