Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doto: Version 1.000 added #8212

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Doto: Version 1.000 added #8212

merged 2 commits into from
Oct 15, 2024

Conversation

emmamarichal
Copy link
Collaborator

@emmamarichal emmamarichal commented Sep 27, 2024

Taken from the upstream repo https://github.com/oliverlalan/Doto at commit oliverlalan/Doto@f46a148.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not) Add designer Oliver Lalan #8213
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

This comment was marked as outdated.

This comment was marked as outdated.

@emmamarichal emmamarichal linked an issue Sep 27, 2024 that may be closed by this pull request
9 tasks
Copy link

FontBakery report

fontbakery version: 0.13.0a1

Check results

[17] Doto[ROND,wght].ttf
🔥 FAIL Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • 🔥 FAIL

    ofl/doto/article/image1.jpg has 1274787 bytes, but the maximum filesize for raster images is 819200 bytes.


    [code: filesize]

  • 🔥 FAIL

    ofl/doto/article/image2.gif has 856947 bytes, but the maximum filesize for raster images is 819200 bytes.


    [code: filesize]

  • 🔥 FAIL

    Image is too large: 1081 x 1351 pixels

Max resolution allowed: 2048 x 1024 pixels

[code: image-too-large]
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]
⚠️ WARN Check mark characters are in GDEF mark glyph class.
  • ⚠️ WARN

    The following mark characters could be in the GDEF mark glyph class:
    acutecomb (U+0301), gravecomb (U+0300), tildecomb (U+0303), uni0302 (U+0302), uni0304 (U+0304), uni0306 (U+0306), uni0307 (U+0307), uni0308 (U+0308), uni030A (U+030A), uni030B (U+030B) and 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: mark-chars]
⚠️ WARN Checking correctness of monospaced metadata.
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Óliver Lalan is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, tifinagh, math, cherokee
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: old-permic, malayalam, hebrew, todhri, duployan, canadian-aboriginal, syriac, tai-le, math, coptic, tifinagh
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0326 COMBINING COMMA BELOW: try adding math
  • U+0327 COMBINING CEDILLA: try adding math
  • U+0328 COMBINING OGONEK: not included in any glyphset definition

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_TransLatin_Pinyin glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ nb_Latn (Norwegian Bokmål)
Some auxiliary glyphs were missing: IJ, ij nl_Latn (Dutch)
[code: warning-language-shaping]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ ĵ j̆ j̇ j̊

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Basaa (Latn, 332,940 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers), Mundani (Latn, 34,000 speakers), Gulay (Latn, 250,478 speakers), Fur (Latn, 1,230,163 speakers), Aghem (Latn, 38,843 speakers), Nzakara (Latn, 50,000 speakers), Lugbara (Latn, 2,200,000 speakers), Vute (Latn, 21,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Nateni (Latn, 100,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Bafut (Latn, 158,146 speakers), Cicipu (Latn, 44,000 speakers), Navajo (Latn, 166,319 speakers), Koonzime (Latn, 40,000 speakers), South Central Banda (Latn, 244,000 speakers), Kom (Latn, 360,685 speakers), Ebira (Latn, 2,200,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ekpeye (Latn, 226,000 speakers), Makaa (Latn, 221,000 speakers), Ma’di (Latn, 584,000 speakers), Southern Kisi (Latn, 360,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Mango (Latn, 77,000 speakers), Sar (Latn, 500,000 speakers), Ejagham (Latn, 120,000 speakers), Dan (Latn, 1,099,244 speakers), Avokaya (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Mfumte (Latn, 79,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Yala (Latn, 200,000 speakers).

[code: soft-dotted]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* 4101 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/doto


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/doto/Doto[ROND,wght].ttf
Dehinted Size 446.2kb
Hinted Size 446.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('ROND-wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 9 52 8 183 0
0% 0% 0% 4% 21% 3% 72% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

@emmamarichal The caps need to be centered in the line
Screenshot 2024-10-01 at 10 16 13

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Oct 1, 2024
@emmamarichal
Copy link
Collaborator Author

Updated

@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_doto branch from 697e89e to 2c982e6 Compare October 9, 2024 13:22
@emmamarichal emmamarichal removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

FontBakery report

fontbakery version: 0.13.0a1

Check results

[17] Doto[ROND,wght].ttf
🔥 FAIL Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • 🔥 FAIL

    ofl/doto/article/image2.gif has 856947 bytes, but the maximum filesize for raster images is 819200 bytes.


    [code: filesize]

  • 🔥 FAIL

    Image is too large: 1081 x 1351 pixels

Max resolution allowed: 2048 x 1024 pixels

[code: image-too-large]
  • 🔥 FAIL

    ofl/doto/article/image1.jpg has 1274787 bytes, but the maximum filesize for raster images is 819200 bytes.


    [code: filesize]

  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]

⚠️ WARN Check mark characters are in GDEF mark glyph class.
  • ⚠️ WARN

    The following mark characters could be in the GDEF mark glyph class:
    acutecomb (U+0301), gravecomb (U+0300), tildecomb (U+0303), uni0302 (U+0302), uni0304 (U+0304), uni0306 (U+0306), uni0307 (U+0307), uni0308 (U+0308), uni030A (U+030A), uni030B (U+030B) and 4 more.

Use -F or --full-lists to disable shortening of long lists.

[code: mark-chars]
⚠️ WARN Checking correctness of monospaced metadata.
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Óliver Lalan is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: coptic, tifinagh, cherokee, math
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: syriac, todhri, coptic, canadian-aboriginal, malayalam, duployan, math, old-permic, tifinagh, hebrew, tai-le
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+0326 COMBINING COMMA BELOW: try adding math
  • U+0327 COMBINING CEDILLA: try adding math
  • U+0328 COMBINING OGONEK: not included in any glyphset definition

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_TransLatin_Pinyin glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŋ, ŋ, Ŧ, ŧ nb_Latn (Norwegian Bokmål)
Some auxiliary glyphs were missing: IJ, ij nl_Latn (Dutch)
[code: warning-language-shaping]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: i̊ i̋ j̀ j́ j̃ j̄ j̈ į̀ į́ į̂ į̃ į̄ į̌

The dot of soft dotted characters should disappear in other cases, for example: ĩ ĭ i̇ ǐ ĩ̦ ĭ̦ i̦̇ i̦̊ i̦̋ ǐ̦ ĩ̧ ĭ̧ i̧̇ i̧̊ i̧̋ ǐ̧ ĵ j̆ j̇ j̊

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Ngbaka (Latn, 1,020,000 speakers), Ekpeye (Latn, 226,000 speakers), Ma’di (Latn, 584,000 speakers), Bafut (Latn, 158,146 speakers), Aghem (Latn, 38,843 speakers), Avokaya (Latn, 100,000 speakers), Igbo (Latn, 27,823,640 speakers), Belarusian (Cyrl, 10,064,517 speakers), Basaa (Latn, 332,940 speakers), Nzakara (Latn, 50,000 speakers), Mundani (Latn, 34,000 speakers), Vute (Latn, 21,000 speakers), Dii (Latn, 71,000 speakers), Kom (Latn, 360,685 speakers), Makaa (Latn, 221,000 speakers), Koonzime (Latn, 40,000 speakers), South Central Banda (Latn, 244,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Nateni (Latn, 100,000 speakers), Yala (Latn, 200,000 speakers), Fur (Latn, 1,230,163 speakers), Ejagham (Latn, 120,000 speakers), Lugbara (Latn, 2,200,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Cicipu (Latn, 44,000 speakers), Sar (Latn, 500,000 speakers), Navajo (Latn, 166,319 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Mango (Latn, 77,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ebira (Latn, 2,200,000 speakers), Gulay (Latn, 250,478 speakers), Southern Kisi (Latn, 360,000 speakers), Zapotec (Latn, 490,000 speakers), Mfumte (Latn, 79,000 speakers), Dan (Latn, 1,099,244 speakers).

[code: soft-dotted]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* A (U+0041) has a counter-clockwise outer contour

* 4101 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/doto


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/doto/Doto[ROND,wght].ttf
Dehinted Size 446.2kb
Hinted Size 446.2kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('ROND-wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 9 52 8 183 0
0% 0% 0% 4% 21% 3% 72% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e added the P4 label Oct 14, 2024
@m4rc1e m4rc1e merged commit e7967b1 into main Oct 15, 2024
8 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_doto branch October 15, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Doto
3 participants