Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mona Sans: Version 2.000 added #8242

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Conversation

emmamarichal
Copy link
Collaborator

@emmamarichal emmamarichal commented Oct 2, 2024

Taken from the upstream repo https://github.com/googlefonts/mona-sans at commit googlefonts/mona-sans@56384c9.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not) Add Designer: Github #8244 Add Designer: Deni Anggara #8245
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@emmamarichal emmamarichal added I New Font -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required labels Oct 2, 2024
@emmamarichal
Copy link
Collaborator Author

Updated

@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_monasans branch from d91b606 to d671c35 Compare October 2, 2024 16:04

This comment was marked as outdated.

@emmamarichal
Copy link
Collaborator Author

Still need to check for designers + images and article. @vv-monsalve I'll ping you once it's ready!

This comment was marked as outdated.

This comment was marked as outdated.

@emmamarichal
Copy link
Collaborator Author

emmamarichal commented Oct 3, 2024

@vv-monsalve
cc @chrissimpkins @davelab6

Some things are still incertain, because we are still waiting for some answers/assets:

  • Article: For now, I put some images they created on the minisite. We can change them later if they provide us some new promotion images.
  • Promotion images: Waiting/In progress
  • Designers profiles: Still waiting, I'll send a new email. Issues created to track them.
  • Designer order: I'll also ask if they prefer to have Github as 'first design' or Deni Anggara. Again, we can change this later, shouldn't be a block.

Fontbakery:

  • 🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
    We can ignore it (cf chat discussion)
  • ⚠️ WARN Detect any interpolation issues in the font.
    I think it's a tool bug, I checked all the concerned Glyphs with the slider, and there is no significant issue visible. But please have a look, I maybe missed something.
  • ⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
    Update reserved_font_name_exceptions.txt fonttools/fontbakery#4846
  • ⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
    Will be solved soon hopefully
  • ⚠️ WARN Ensure variable fonts include an avar table.
    It's a linear design space, user values = design values.
  • ⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. -> Article page is too short!
    I'll ask if they can provide us a longer description.

@emmamarichal emmamarichal linked an issue Oct 3, 2024 that may be closed by this pull request
@emmamarichal emmamarichal removed the -- Needs Meta/Desc/License changes Corrections in METADATA.pb or html snippet or License file required label Oct 3, 2024
@emmamarichal
Copy link
Collaborator Author

@vv-monsalve I finally removed all the images, since they come from the minisite, where mona and hubot are mixed together , and the images were using both. We then will wait for proper promotion images from their side!

Copy link

github-actions bot commented Oct 4, 2024

FontBakery report

fontbakery version: 0.13.0a1

Check results

[19] MonaSans-Italic[wdth,wght].ttf
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/github/mona-sans', font copyright string has 'https://github.com/github/mona-sans' and OFL text has 'https://github.com/github/mona-sans'

[code: mismatch]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 1 start point differs in glyph 'zero.tf.ss08' between location wdth=100,wght=200 and location wdth=75,wght=200

- Contour 1 start point differs in glyph 'zero.tf.ss08' between location wdth=100,wght=900 and location wdth=75,wght=300

- Contour 1 start point differs in glyph 'zero.tf' between location wdth=100,wght=200 and location wdth=75,wght=200

- Contour 1 start point differs in glyph 'zero.tf' between location wdth=100,wght=900 and location wdth=75,wght=300

[code: interpolation-issues]

⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

- f + y

- t + i

- t + t

[code: lacks-kern-info]

⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    periodcentered.loclCAT.case.ss01


    [code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]

  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]

⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Github is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Deni Anggara is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2022 The Mona Sans Project Authors (https://github.com/github/mona-sans), with Reserved Font Name "Mona"") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, math, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, todhri, duployan, canadian-aboriginal, malayalam, coptic, syriac, tifinagh, hebrew, math, old-permic
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 78 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'GTHB' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/monasans


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/monasans/MonaSans-Italic[wdth,wght].ttf
Dehinted Size 352.0kb
Hinted Size 352.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']


    [code: version-not-detected]
[19] MonaSans[wdth,wght].ttf
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/github/mona-sans', font copyright string has 'https://github.com/github/mona-sans' and OFL text has 'https://github.com/github/mona-sans'

[code: mismatch]
⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
  • ⚠️ WARN

    Lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    dcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    lcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

  • ⚠️ WARN

    tcaron is decomposed and therefore could not be checked. Please check manually.


    [code: decomposed-outline]

⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 in glyph 'V': becomes underweight between wdth=100,wght=200 and wdth=75,wght=200.

- Contour 0 in glyph 'Y': becomes underweight between wdth=100,wght=200 and wdth=75,wght=200.

[code: interpolation-issues]

⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

- f + y

- t + i

- t + t

[code: lacks-kern-info]

⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.


    [code: missing-avar]
⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    periodcentered.loclCAT.case.ss01


    [code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page is too short!


    [code: length-requirements-not-met]

  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]

⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Github is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

  • ⚠️ WARN

    It seems that Deni Anggara is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]

⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2022 The Mona Sans Project Authors (https://github.com/github/mona-sans), with Reserved Font Name "Mona"") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, math, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, todhri, duployan, canadian-aboriginal, malayalam, coptic, syriac, tifinagh, hebrew, math, old-permic
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 78 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Shapes languages in all GF glyphsets.
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
[code: warning-language-shaping]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value 'GTHB' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/monasans


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/monasans/MonaSans[wdth,wght].ttf
Dehinted Size 340.9kb
Hinted Size 341.0kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wdth-wght-ital', 2)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 24 85 13 364 0
0% 0% 0% 5% 17% 3% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal requested a review from m4rc1e October 9, 2024 15:58
@vv-monsalve
Copy link
Collaborator

Hi @emmamarichal, I've run new local proofs, including Windows, and they work okay. So this LGTM

@vv-monsalve vv-monsalve merged commit 83b7192 into main Oct 11, 2024
8 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_monasans branch October 11, 2024 22:27
@m4rc1e m4rc1e added P1 and removed P1 labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Add Mona Sans
3 participants