-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mona Sans: Version 2.000 added #8242
Conversation
Taken from the upstream repo https://github.com/googlefonts/mona-sans at commit googlefonts/mona-sans@56384c9.
Updated |
d91b606
to
d671c35
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Still need to check for designers + images and article. @vv-monsalve I'll ping you once it's ready! |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@vv-monsalve Some things are still incertain, because we are still waiting for some answers/assets:
Fontbakery:
|
@vv-monsalve I finally removed all the images, since they come from the minisite, where mona and hubot are mixed together , and the images were using both. We then will wait for proper promotion images from their side! |
FontBakery reportfontbakery version: 0.13.0a1 Check results[19] MonaSans-Italic[wdth,wght].ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/github/mona-sans', font copyright string has 'https://github.com/github/mona-sans' and OFL text has 'https://github.com/github/mona-sans' [code: mismatch]
|
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
⚠️ WARNOS/2 VendorID value 'GTHB' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
[code: unknown]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/monasans/MonaSans-Italic[wdth,wght].ttf | |
---|---|
Dehinted Size | 352.0kb |
Hinted Size | 352.0kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][19] MonaSans[wdth,wght].ttf
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
- 🔥 FAIL
Repository URL is https://github.com/googlefonts/mona-sans
But: font copyright string has 'https://github.com/github/mona-sans', font copyright string has 'https://github.com/github/mona-sans' and OFL text has 'https://github.com/github/mona-sans'
[code: mismatch]⚠️ WARN Check accent of Lcaron, dcaron, lcaron, tcaron
-
⚠️ WARNLcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNdcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNlcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline] -
⚠️ WARNtcaron is decomposed and therefore could not be checked. Please check manually.
[code: decomposed-outline]
⚠️ WARN Detect any interpolation issues in the font.
⚠️ WARNInterpolation issues were found in the font:
- Contour 0 in glyph 'V': becomes underweight between wdth=100,wght=200 and wdth=75,wght=200.
- Contour 0 in glyph 'Y': becomes underweight between wdth=100,wght=200 and wdth=75,wght=200.
[code: interpolation-issues]
⚠️ WARN Is there kerning info for non-ligated sequences?
⚠️ WARNGPOS table lacks kerning info for the following non-ligated sequences:
- f + f
- f + i
- f + l
- f + y
- t + i
- t + t
[code: lacks-kern-info]
⚠️ WARN Ensure variable fonts include an avar table.
⚠️ WARNThis variable font does not have an avar table. Most variable fonts should include an avar table to correctly define axes progression rates.
[code: missing-avar]
⚠️ WARN Glyph names are all valid?
⚠️ WARNThe following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
periodcentered.loclCAT.case.ss01
[code: legacy-long-names]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
-
⚠️ WARNArticle page is too short!
[code: length-requirements-not-met] -
⚠️ WARNArticle page lacks visual assets.
[code: missing-visual-asset]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
-
⚠️ WARNIt seems that Github is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.
[code: profile-not-found] -
⚠️ WARNIt seems that Deni Anggara is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.
[code: profile-not-found]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠️ WARNMETADATA.pb: copyright field ("Copyright 2022 The Mona Sans Project Authors (https://github.com/github/mona-sans), with Reserved Font Name "Mona"") contains "Reserved Font Name". This is an error except in a few specific rare cases.
[code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, coptic, math, tifinagh
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, todhri, duployan, canadian-aboriginal, malayalam, coptic, syriac, tifinagh, hebrew, math, old-permic
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
- U+0312 COMBINING TURNED COMMA ABOVE: try adding math 78 more.
Use -F or --full-lists to disable shortening of long lists.
Or you can add the above codepoints to one of the subsets supported by the font: latin
, latin-ext
, menu
, vietnamese
⚠️ WARN Shapes languages in all GF glyphsets.
⚠️ WARNGF_Phonetics_SinoExt glyphset:
WARN messages | Languages |
---|---|
Some auxiliary glyphs were missing: ſ | de_Latn (German) and fr_Latn (French) |
Some auxiliary glyphs were missing: Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ | fi_Latn (Finnish) |
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
⚠️ WARNOS/2 VendorID value 'GTHB' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
[code: unknown]
ℹ️ INFO Show hinting filesize impact.
- ℹ️ INFO
Hinting filesize impact:
ofl/monasans/MonaSans[wdth,wght].ttf | |
---|---|
Dehinted Size | 340.9kb |
Hinted Size | 341.0kb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 24 | 85 | 13 | 364 | 0 |
0% | 0% | 0% | 5% | 17% | 3% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Hi @emmamarichal, I've run new local proofs, including Windows, and they work okay. So this LGTM |
Taken from the upstream repo https://github.com/googlefonts/mona-sans at commit googlefonts/mona-sans@56384c9.
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectsprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.