-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iansui: 1.003 added #8590
Iansui: 1.003 added #8590
Conversation
Taken from the upstream repo https://github.com/ButTaiwan/iansui at commit https://github.com/ButTaiwan/iansui/tree/41190e8094a9a5b47626c5d927daf0dcb226babf
Removed from all files
FontBakery reportfontbakery version: 0.13.0a5 Checks with FATAL resultsThese must be addressed first. [1] Iansui-Regular.ttf☠ FATAL Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
All other checks[25] Iansui-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
[code: unattached-dotted-circle-marks]
|
ofl/iansui/Iansui-Regular.ttf | |
---|---|
Dehinted Size | 7.9Mb |
Hinted Size | 7.9Mb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
- vhea
- vmtx
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 1 | 2 | 16 | 73 | 8 | 152 | 0 |
0% | 0% | 1% | 6% | 29% | 3% | 60% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Updating subsets / primary scripts based on Cactus Classical Serif.
FontBakery reportfontbakery version: 0.13.0a5 Checks with FATAL resultsThese must be addressed first. [1] Iansui-Regular.ttf☠ FATAL Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
All other checks[25] Iansui-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
[code: unattached-dotted-circle-marks]
|
ofl/iansui/Iansui-Regular.ttf | |
---|---|
Dehinted Size | 7.9Mb |
Hinted Size | 7.9Mb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
- vhea
- vmtx
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 1 | 2 | 16 | 73 | 8 | 152 | 0 |
0% | 0% | 1% | 6% | 29% | 3% | 60% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
BTW, for the |
Images in articles must be stored within the article dir. See how Playwrite has done it, https://github.com/google/fonts/tree/main/ofl/playwriteno/article |
Correcting Article per Marc's feedback
@m4rc1e Thanks Marc! Done. |
FontBakery reportfontbakery version: 0.13.0a5 Check results[26] Iansui-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
[code: unattached-dotted-circle-marks]
|
ofl/iansui/Iansui-Regular.ttf | |
---|---|
Dehinted Size | 7.9Mb |
Hinted Size | 7.9Mb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
- vhea
- vmtx
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 17 | 73 | 8 | 152 | 0 |
0% | 0% | 1% | 7% | 29% | 3% | 60% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontBakery reportfontbakery version: 0.13.0a5 Check results[26] Iansui-Regular.ttf🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
[code: unattached-dotted-circle-marks]
|
ofl/iansui/Iansui-Regular.ttf | |
---|---|
Dehinted Size | 7.9Mb |
Hinted Size | 7.9Mb |
Increase | 24 bytes |
Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
- vhea
- vmtx
[code: optional-tables]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
- ℹ️ INFO
Please consider adding a family.minisite_url entry.
[code: lacks-minisite-url]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 17 | 73 | 8 | 152 | 0 |
0% | 0% | 1% | 7% | 29% | 3% | 60% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Hi @aaronbell, Fontbakery looks good to me! I just have a question about Cyrillic, I can see that several glyphs have been drawn, but I don't suppose they'll do any good given the spacing? |
@emmamarichal I'm sorry, I must have missed your comment. This sort of situation is not uncommon with Japanese fonts as Cyrillic (and Greek) is expected to be included, but is usually designed as full width rather than proportional. As Iansui is based on a Japanese font, it has the same characteristic. GF has allowed in many fonts with similar characteristics. |
subsets: "latin" | ||
subsets: "latin-ext" | ||
subsets: "menu" | ||
subsets: "symbols2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emmamarichal subset symbols2
defined here
@emmamarichal what is the string used for that? |
鑑於對人權嘅無視同侮蔑已經發展為野蠻暴行,呢啲暴行玷污咗人類嘅良心,而一個人人享有言論同信仰自由並免予恐懼同匱乏嘅世界嘅來臨 |
Taken from the upstream repo https://github.com/ButTaiwan/iansui at commit https://github.com/ButTaiwan/iansui/tree/41190e8094a9a5b47626c5d927daf0dcb226babf
New font project as part of the GF CJK Q4 onboarding effort. Resolves #7742.
Some existing
FAILS
with FB that I do not believe are problematic at this time.com.google.fonts/check/glyph_coverage
- Font contains GF Corecom.google.fonts/check/dotted_circle
- Font is primarily intended for CJK usecom.google.fonts/check/case_mapping
- This is an upstream (Klee) issue that I don't think needs attending to for this project at this time.