Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'make format'-related CI failure #142

Merged
merged 2 commits into from
Aug 29, 2019
Merged

Fix 'make format'-related CI failure #142

merged 2 commits into from
Aug 29, 2019

Conversation

ebiggers
Copy link
Collaborator

@ebiggers ebiggers commented Aug 25, 2019

  • Exclude generated files from 'make format'
  • Run 'make format' with latest version of goimports

Due to a goimports update, 'make format' is now changing metadata.pb.go.
But this fix can't be committed because this file is generated by
'make gen'.

Fix this by not formatting generated files.
This fixes a CI failure, caused by goimports changing how it formats the
imports.
@ebiggers ebiggers changed the title Format code with latest version of goimports Fix 'make format'-related CI failure Aug 29, 2019
@ebiggers
Copy link
Collaborator Author

Updated this pull request to actually fix the CI failure... Turns out that make gen was also conflicting with make format.

@josephlr josephlr merged commit 8a3acda into google:master Aug 29, 2019
@ebiggers ebiggers deleted the goimports branch August 29, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants