Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis CI to GitHub Actions #267

Merged
merged 2 commits into from
Nov 26, 2020
Merged

Switch from Travis CI to GitHub Actions #267

merged 2 commits into from
Nov 26, 2020

Conversation

ebiggers
Copy link
Collaborator

travis-ci.org is being shut down, so switch to GitHub Actions.

It should be mostly equivalent, but I did drop functionality in a couple cases:

  • Publishing release binaries. I don't think providing Linux binaries is useful, since people build their own anyway. So I left this out.

  • Build and testing on ppc64le. GitHub Actions only natively supports x86. I tried uraimo/run-on-arch-action, which uses Docker and QEMU user-mode emulation, but the fscrypt tests can't be run because QEMU user-mode emulation doesn't support all the needed system calls.

Otherwise the cli tests fail when executed from GitHub Actions.
@ebiggers
Copy link
Collaborator Author

Note, GitHub Actions isn't actually running on this pull request yet. I need to figure out why. It was working for me on a test pull request on my fork (https://github.com/ebiggers/fscrypt/pull/1/checks).

travis-ci.org is being shut down, so switch to GitHub Actions.

It should be mostly equivalent, but I did drop functionality in a couple
cases:

- Publishing release binaries.  I don't think providing Linux binaries
  is useful, since people build their own anyway.  So I left this out.

- Build and testing on ppc64le.  GitHub Actions only natively supports
  x86.  I tried uraimo/run-on-arch-action, which uses Docker and QEMU
  user-mode emulation, but the fscrypt tests can't be run because
  QEMU user-mode emulation doesn't support all the needed system calls.
@ebiggers
Copy link
Collaborator Author

I pushed this pull request's branch to origin/github-actions, and that caused the GitHub Actions checks to run. I'm not sure why they didn't run for the pull request itself. Maybe they won't run on pull requests until this pull request is merged.

@josephlr, any idea why there is now also a Cirrus CI check, which is failing?

@josephlr
Copy link
Member

@josephlr, any idea why there is now also a Cirrus CI check, which is failing?

Ya, I was originally going to switch things to CirrusCI, but never got around to it. I've denied the hook, so let's see if this disables the check.

@josephlr josephlr merged commit 0692c00 into google:master Nov 26, 2020
@ebiggers ebiggers deleted the github-actions branch November 26, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants