Adding an overload of ReadFilesFromDirectory that takes in a filename… #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_pattern as a second argument.
|
@lszekeres Could you please review? |
|
There is an Actions error that doesn't seem related to my change? |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
|
Thanks a lot! We'd rather avoid using std::regex or depending on RE2 here. Would this work: #1534, ie using a filter function? If yes, I can check this in |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
|
@lszekeres Yaa looks perfect! thanks! |
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
… name. Based on #1520. PiperOrigin-RevId: 719678199
copybara-service bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
… name. Based on #1520. PiperOrigin-RevId: 721891322
|
replaced by the commit: 2efcd1e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entry.path().extension()since my current use-case is for matching specific file extensions. But I went with regex since it gives more flexibility.