Skip to content

Commit

Permalink
Fixed updateThreadsStatus to modidfy original thread instances, rathe…
Browse files Browse the repository at this point in the history
…r than modifying copies
  • Loading branch information
jishi9 committed Dec 24, 2015
1 parent d2213d9 commit 39155d2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion review/review.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ func updateThreadsStatus(threads []CommentThread) *bool {
sort.Sort(byTimestamp(threads))
noUnresolved := true
var result *bool
for _, thread := range threads {
for i := range threads {
thread := &threads[i]
thread.updateResolvedStatus()
if thread.Resolved != nil {
noUnresolved = noUnresolved && *thread.Resolved
Expand Down

0 comments on commit 39155d2

Please sign in to comment.