Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug fix for thread comment status #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hazbo
Copy link
Contributor

@hazbo hazbo commented Dec 23, 2015

As pointed out in #22, the status for every comment seems to be fyi.
This seems to fix that.

As pointed out in google#22, the status for every comment seems to be fyi.
This seems to fix that.
@barbastan
Copy link

Thanks!

Barbara

On Wednesday, December 23, 2015, Harry Lawrence [email protected]
wrote:

As pointed out in #22 #22,
the status for every comment seems to be fyi.

This seems to fix that.

You can view, comment on, or merge this pull request online at:

#23
Commit Summary

  • Possible bug fix for thread comment status

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#23.

@hazbo
Copy link
Contributor Author

hazbo commented Dec 24, 2015

This may now be redundant as of #24

@ojarjur
Copy link
Collaborator

ojarjur commented Jan 4, 2016

There's the overall status of the entire sub-thread, and the resolved bit for the individual comment. Right now we are only displaying the overall status.

I wouldn't want to replace the overall status with the individual comment's status (which is what this PR currently does), but I would not object to displaying both statuses if we can format the output nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants