Skip to content

Commit

Permalink
Merge pull request #635 from google/win-headers
Browse files Browse the repository at this point in the history
Use generated config.h for Windows.
  • Loading branch information
sergiud authored Apr 6, 2021
2 parents 82320a8 + 1041a22 commit 36e6ed9
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions bazel/glog.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs):
name = "glog",
visibility = ["//visibility:public"],
srcs = [
":config_h",
"src/base/commandlineflags.h",
"src/base/googleinit.h",
"src/base/mutex.h",
Expand All @@ -133,7 +134,7 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs):
"src/vlog_is_on.cc",
] + select({
"@bazel_tools//src/conditions:windows": windows_only_srcs,
"//conditions:default": [":config_h"],
"//conditions:default": [],
}),
hdrs = [
"src/glog/log_severity.h",
Expand All @@ -144,8 +145,8 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs):
],
strip_include_prefix = "src",
defines = select({
# We need to override the default GOOGLE_GLOG_DLL_DECL from
# src/glog/*.h to match src/windows/config.h.
# GOOGLE_GLOG_DLL_DECL is normally set by export.h, but that's not
# generated for Bazel.
"@bazel_tools//src/conditions:windows": ["GOOGLE_GLOG_DLL_DECL=__declspec(dllexport)"],
"//conditions:default": [],
}),
Expand Down

0 comments on commit 36e6ed9

Please sign in to comment.