Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacktrace is not printed by failure signal handler when built with Bazel #346

Closed
nya3jp opened this issue Jul 18, 2018 · 0 comments · Fixed by #347
Closed

Stacktrace is not printed by failure signal handler when built with Bazel #346

nya3jp opened this issue Jul 18, 2018 · 0 comments · Fixed by #347

Comments

@nya3jp
Copy link
Contributor

nya3jp commented Jul 18, 2018

When glog is built with Bazel, failure signal handler is unable to print stack trace.

*** Aborted at 1531880485 (unix time) try "date -d @1531880485" if you are using GNU date ***
PC: @ 0x0 (unknown)
zsh: segmentation fault bazel run :hello

On Linux, no stacktrace is shown. On macOS, it enters deadlock for some reason and can be killed only with SIGKILL (no Ctrl+C), which is worse.
nya3jp added a commit to nya3jp/glog that referenced this issue Jul 18, 2018
@nya3jp
Fix stacktrace on bazel build.
b9e235b 
We need at least following defs to be set to print stacktrace in
failure signal handler.

- HAVE_UNWIND_H: On Linux and macOS. unwind.h is usually present
  by default on those systems.
- HAVE_DLADDR: On macOS.

Windows is not cared because glog can not be built with bazel
on Windows today.

Resolves google#346.
nya3jp added a commit to nya3jp/glog that referenced this issue Jul 18, 2018
@nya3jp
Fix stacktrace on Bazel build.
2645940 
We need at least following defs to be set to print stacktrace in
failure signal handler.

- HAVE_UNWIND_H: On Linux and macOS. unwind.h is usually present
  by default on those systems.
- HAVE_DLADDR: On macOS.

Note that today glog does not build with Bazel on Windows.

Resolves google#346.
@nya3jp nya3jp mentioned this issue Jul 18, 2018
Merged
@ukai ukai closed this as completed in #347 Apr 12, 2019
@sergiud sergiud mentioned this issue May 6, 2021
Merged
@kuntryn kuntryn mentioned this issue Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stacktrace on Bazel build. nya3jp/glog
1 participant
@nya3jp