Fix missing deletion of custom Logger #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If the user specifies a custom Logger via SetLogger(), the docs state that the logging module takes ownership of it. Prior to this change, the logging library was not deleting a custom logger when the LogDestination which owns it was destroyed.
alexsmac
force-pushed
the
fix-custom-logger-deletion
branch
from
9dd7776 to
0a6704b
Compare
sergiud
approved these changes
Mar 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that the logging module takes ownership of it. Prior to this change,
the logging library was not deleting a custom logger when the
LogDestination which owns it was destroyed.