Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedupe layers when writing a multi-image tarball #265

Closed
jonjohnsonjr opened this issue Aug 28, 2018 · 0 comments · Fixed by #620
Closed

Dedupe layers when writing a multi-image tarball #265

jonjohnsonjr opened this issue Aug 28, 2018 · 0 comments · Fixed by #620
Labels
good first issue Good for newcomers

Comments

@jonjohnsonjr
Copy link
Collaborator

jonjohnsonjr commented Aug 28, 2018 •
edited
Loading

#260 added support for multi-image tarballs, but doesn't check to see if a layer is already present in the tarball before writing it. Any overlap between two images' layers will result in writing duplicate layers.

/cc @sharifelgamal
@jonjohnsonjr jonjohnsonjr added the good first issue Good for newcomers label Aug 28, 2018
djfinlay added a commit to djfinlay/go-containerregistry that referenced this issue Nov 27, 2019
@djfinlay
Deduplicate layers when writing a multi-image tarball
0a22861 
Fixes google#265
djfinlay added a commit to djfinlay/go-containerregistry that referenced this issue Nov 27, 2019
@djfinlay
Deduplicate layers when writing a multi-image tarball
735dc6c 
Fixes google#265
djfinlay added a commit to djfinlay/go-containerregistry that referenced this issue Nov 27, 2019
@djfinlay
Deduplicate layers when writing a multi-image tarball
834a898 
Fixes google#265
djfinlay added a commit to djfinlay/go-containerregistry that referenced this issue Nov 27, 2019
@djfinlay
Deduplicate layers when writing a multi-image tarball
5f7c8cf 
Fixes google#265
@djfinlay djfinlay mentioned this issue Nov 27, 2019
Merged
jonjohnsonjr pushed a commit that referenced this issue Dec 2, 2019
@djfinlay @jonjohnsonjr
Deduplicate layers when writing a multi-image tarball (#620)
2ce3ea9 
Fixes #265
@copymark copymark mentioned this issue Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate layers when writing a multi-image tarball djfinlay/go-containerregistry
1 participant
@jonjohnsonjr