Dedupe layer uploads where possible #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #396 +/- ##
=========================================
+ Coverage 51.67% 51.87% +0.2%
=========================================
Files 78 78
Lines 3712 3728 +16
=========================================
+ Hits 1918 1934 +16
+ Misses 1504 1501 -3
- Partials 290 293 +3
Continue to review full report at Codecov.
|
jonjohnsonjr
reviewed
Mar 6, 2019
imjasonh
changed the title
clrprod
reviewed
Mar 6, 2019
pkg/v1/remote/write.go
Outdated
| var g errgroup.Group | ||
| seen := map[v1.Hash]struct{}{} |
There was a problem hiding this comment.
If you call this uploaded - it'll probably be a little clearer.
Also if you use map[v1.Hash]bool, then you can do
if uploaded[h]
jonjohnsonjr
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue in GoogleContainerTools/kaniko#599
Prior to #301 we deduped layers using
BlobSet, but that was dropped when some layers might not be digestable ahead of time.TODO: tests, I wanted to get this out in case there were comments about the overall direction.