-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement incremental daemon loading #559
Conversation
Continuation of this PR: google#209 This should be considered a relatively advanced option, but for folks that know what they are doing you can reduce the amount of data that you need to encode in the tarball for the daemon to load it. The ultimate use case of this option will be from daemon.Write, which currently uses the docker load interface to pull image into the daemon, however, this currently reuploads (and redownloads) the base image on each write in context like ko. If we can determine the set of layers that already exist in the daemon we can elide these from the tarball to dramatically improve performance. Related: google#205
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
- Coverage 72.57% 71.82% -0.76%
==========================================
Files 94 95 +1
Lines 4241 4323 +82
==========================================
+ Hits 3078 3105 +27
- Misses 769 813 +44
- Partials 394 405 +11
Continue to review full report at Codecov.
|
Running the POC:
|
787cb3a
to
71088db
Compare
This Pull Request is stale because it has been open for 90 days with |
WIP
Fixes #205