Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image tests for the experiments binary #378

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

JoshuaKrstic
Copy link
Contributor

@JoshuaKrstic JoshuaKrstic commented Oct 24, 2023

Adds image tests for the experiments binary

Tests added:

  • VM started, LaunchSpec has the TestFeature enabled

Tests still needed:

  • VM started, binary is replaced with a failing binary, LaunchSpec has the TestFeature disabled
  • VM started, binary is replaced with binary that writes random experiments, LaunchSpec has the TestFeature disabled

@JoshuaKrstic JoshuaKrstic force-pushed the imagetest branch 9 times, most recently from 700772c to d72d328 Compare October 25, 2023 22:58
@JoshuaKrstic JoshuaKrstic requested a review from alexmwu October 25, 2023 23:10
Copy link
Contributor

@alexmwu alexmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have the tests run successfully before merging. (I think we may need to increase our quota)

@JoshuaKrstic JoshuaKrstic merged commit eab8fa8 into google:main Oct 26, 2023
11 checks passed
alexmwu added a commit to alexmwu/go-tpm-tools that referenced this pull request Oct 27, 2023
New Features:
[launcher] Add experiment support google#352
[launcher] Integrate signature discovery client into attestation agent google#343

Bug Fixes:
Make launcher host tmp directory before experiment fetch google#363

Other Changes:
[launcher] Print kernel cmdline on builds google#268
Import latest version of go-tdx-guest google#373
[launcher] Print signature details instead of signature object google#374
[launcher] Add image tests for the experiments binary google#378
Update go-sev-guest to v0.9.3 google#381
@alexmwu alexmwu mentioned this pull request Oct 27, 2023
alexmwu added a commit that referenced this pull request Oct 27, 2023
New Features:
[launcher] Add experiment support #352
[launcher] Integrate signature discovery client into attestation agent #343

Bug Fixes:
Make launcher host tmp directory before experiment fetch #363

Other Changes:
[launcher] Print kernel cmdline on builds #268
Import latest version of go-tdx-guest #373
[launcher] Print signature details instead of signature object #374
[launcher] Add image tests for the experiments binary #378
Update go-sev-guest to v0.9.3 #381
@JoshuaKrstic JoshuaKrstic deleted the imagetest branch October 14, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants