Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning maybe-uninitialized #3024

Merged

Conversation

Thomas-Barbier-1A
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes label Sep 24, 2020
@Maximuscari205
Copy link

Fixed

@Thomas-Barbier-1A
Copy link
Contributor Author

@Maximuscari205 which commit fix it? I still have the issue with Head of master with gcc (GCC) 11.0.0 20200803
I think this PR is necessary to fix the issue.

@derekmauro derekmauro self-assigned this Sep 29, 2020
suertreus added a commit that referenced this pull request Sep 29, 2020
@suertreus suertreus merged commit a0cbbba into google:master Sep 30, 2020
@Thomas-Barbier-1A Thomas-Barbier-1A deleted the fix_warning_maybe_unintialized branch September 30, 2020 08:19
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 6, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 6, 2021
to include the fix of google/googletest#3024.
because this fix is not included in the latest release (1.10.0) of
googletest yet at the time of writing. the submodule is referencing the
latest master HEAD of google/googletest.

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 6, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 7, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 8, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
tchaikov added a commit to tchaikov/ceph that referenced this pull request Jan 8, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
hejllukas added a commit to prusa3d/PrusaSlicer that referenced this pull request May 1, 2021
It was added patch from google/googletest#3024 to silence error=maybe-uninitialized warning.
tchaikov added a commit to tchaikov/ceph that referenced this pull request May 25, 2021
to include the fix of google/googletest#3024

otherwise GCC-11 fails to compile the tests with following warning:

In file included from ../src/googletest/googletest/src/gtest-all.cc:42:
../src/googletest/googletest/src/gtest-death-test.cc: In function ‘bool testing::internal::StackGrowsDown()’:
../src/googletest/googletest/src/gtest-death-test.cc:1301:24: error: ‘dummy’ may be used uninitialized [-Werror=maybe-uninitialized]
 1301 |   StackLowerThanAddress(&dummy, &result);
      |   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1290:13: note: by argument 1 of type ‘const void*’ to ‘void testing::internal::StackLowerThanAddress(const void*, bool*)’ declared here
 1290 | static void StackLowerThanAddress(const void* ptr, bool* result) {
      |             ^~~~~~~~~~~~~~~~~~~~~
../src/googletest/googletest/src/gtest-death-test.cc:1299:7: note: ‘dummy’ declared here
 1299 |   int dummy;
      |       ^~~~~
cc1plus: all warnings being treated as errors

Signed-off-by: Kefu Chai <[email protected]>
hejllukas added a commit to prusa3d/PrusaSlicer that referenced this pull request Jun 26, 2021
It was added patch from google/googletest#3024 to silence error=maybe-uninitialized warning.
hejllukas added a commit to prusa3d/PrusaSlicer that referenced this pull request Jul 12, 2021
It was added patch from google/googletest#3024 to silence error=maybe-uninitialized warning.
naruhitokaide added a commit to naruhitokaide/core-wallet that referenced this pull request Aug 23, 2022
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
webcat359 added a commit to webcat359/wallet-core that referenced this pull request Aug 29, 2022
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
algoriddle added a commit to algoriddle/faiss that referenced this pull request Oct 19, 2022
Summary:
Due to google/googletest#3219 gtest doesn't compile with gcc 11 - Ubuntu 22.04 has GCC 11.2 currently.

The fix was google/googletest#3024 so I'm bumping gtest to latest.

Differential Revision: D40512746

fbshipit-source-id: b938eec96f0cb6e13e20daab529f97527c8e31c0
facebook-github-bot pushed a commit to facebookresearch/faiss that referenced this pull request Oct 20, 2022
Summary:
Pull Request resolved: #2538

Due to google/googletest#3219 gtest doesn't compile with gcc 11 - Ubuntu 22.04 has GCC 11.2 currently.

The fix was google/googletest#3024 so I'm bumping gtest to latest.

Reviewed By: alexanderguzhva

Differential Revision: D40512746

fbshipit-source-id: 75f3c3c7f8a117af8430c2f74a7f8d164ca9877b
Ninja-21-dev added a commit to Ninja-21-dev/core-cross-blockchain-wallet that referenced this pull request Oct 28, 2022
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
tomjnixon added a commit to ebu/ear-production-suite that referenced this pull request Nov 14, 2022
tomjnixon added a commit to ebu/ear-production-suite that referenced this pull request Nov 14, 2022
tomjnixon added a commit to ebu/ear-production-suite that referenced this pull request Nov 17, 2022
crazycodecreator007 added a commit to crazycodecreator007/core-wallet that referenced this pull request Feb 8, 2023
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
BerndDoser added a commit to HITS-MBM/gromacs-fda that referenced this pull request Jul 13, 2023
0xExp-po added a commit to 0xExp-po/core-wallet that referenced this pull request Jan 9, 2024
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
10kick-1goal added a commit to 10kick-1goal/core-wallet that referenced this pull request Jan 10, 2024
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
Herocoin816 added a commit to Herocoin816/Wallet that referenced this pull request Sep 16, 2024
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
gncao523 added a commit to gncao523/core-wallet that referenced this pull request Nov 15, 2024
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
unicorn79dev added a commit to unicorn79dev/core-wallet that referenced this pull request Jan 13, 2025
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
christophehaight0307 pushed a commit to christophehaight0307/core-wallet that referenced this pull request Jan 21, 2025
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
Mario-cmd-4224 added a commit to Mario-cmd-4224/wallet that referenced this pull request Feb 10, 2025
This fixes a build issue caused by gcc 11 changing the rules about what constitutes a `-Werror=maybe-uninitialized` error (see google/googletest#3024)
As a side benefit, this simplifies the build  script by removing the need for a few patches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants