Fix issue with recursive type variable protections to fix #1390

[mcumings]

When a type variable is referenced multiple times it needs to resolve to the same value. Previously, the second attempt would abort resolution early in order to protect against infinite recursion.

NOTE: I could use some scrutiny on this as I don't fully understand the implications of all the code branches. This commit does resolve the issue but stylistically I'm not really sold on breaking out of the while loop in order to capture the final result for subsequent resolution attempts.

Fixes #1390

[mcumings]

The Codacy check is flagging existing code with a legitimate == check. Not sure how I should respond to that...

[lyubomyr-shaydariv]

The Codacy check is flagging existing code with a legitimate == check. Not sure how I should respond to that...

Neither componentType nor newComponentType are declared as java.lang.Class instances, hence == is not guaranteed to work properly. My IntelliJ IDEA code analisys reports a lot of ==/equals issues for $Gson$Type too, and I think you should simply rewrite it using equals() (the old code is dated 2010, most likely prior to Codacy). Codacy seems to analyze the modified code, so that's probably why it reports your change only.

[mcumings]

Fair point. There were a couple points in the resolve method where instance equality checks were sufficient (i.e., it was checking to see if the original value was being returned, etc.). I updated the others to use the equal method. I didn't want to spread this too broadly however, so I stopped there.

Cadacy is now happy. 😃

[Marcono1234]

Could you please edit the description and include:

Fixes #1390

It appears otherwise GitHub does not understand that this pull request and the issue are related.

[mcumings]

Done. Hopefully this PR isn't too old as to be useless at this point.

[Marcono1234]

Thanks! There haven't been any other changes to $Gson$Types since then so this PR is still useful.
Hopefully the maintainers have a look at all the open pull requests soon.