Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ISO8601UtilsTest run successfully in any time zone #1809

Closed

Conversation

danielthegray
Copy link

In some timezones, ISO8601UtilsTest fails with:

Failed tests:   testDateFormatString(com.google.gson.internal.bind.util.ISO8601UtilsTest):
      expected:<2018-06-2[5]> but was:<2018-06-2[4]>

This PR simply forced the timezone to always be UTC so that the test passes regardless of the timezone of the person running the test.

@google-cla
Copy link

google-cla bot commented Oct 21, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 21, 2020
@danielthegray
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 21, 2020
@Marcono1234
Copy link
Collaborator

@danielthegray
Copy link
Author

Ahh apologies... I was looking for something too specific. I hope something gets merged soon!

@danielthegray
Copy link
Author

danielthegray commented Oct 22, 2020

The other pull requests are more complete and solve the problem. It should not be hard to get them merged in! Some action would be nice on the maintainer's side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants