Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure fetcher authorization delays support stop callbacks. #422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomasvl
Copy link
Member

No description provided.

@thomasvl thomasvl requested review from dmaclach and removed request for dmaclach November 19, 2024 22:12
@thomasvl thomasvl marked this pull request as draft November 20, 2024 15:16
@thomasvl
Copy link
Member Author

Need to give this some more through for the case where the stop call comes in before starting an authorization delay.

@thomasvl thomasvl marked this pull request as ready for review November 20, 2024 16:54
@thomasvl thomasvl requested a review from dmaclach November 20, 2024 16:54
@thomasvl
Copy link
Member Author

Ok, this seems to be more complete for stopFetching through the auth sub part of the begin fetching flow.

dmaclach
dmaclach previously approved these changes Nov 27, 2024
Sources/Core/GTMSessionFetcher.m Show resolved Hide resolved
Sources/Core/GTMSessionFetcher.m Outdated Show resolved Hide resolved
UnitTests/GTMSessionFetcherFetchingTest.m Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants