Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix javadoc link. #2908

Closed

Conversation

hawjo06
Copy link

@hawjo06 hawjo06 commented Aug 13, 2017

The link was generated as plaintext. The change will result in the link
being rendered as a hyperlink.

The link was generated as plaintext. The change will result in the link
being rendered as a hyperlink.
@kluever kluever added package=collect type=api-docs Change/add API documentation labels Aug 13, 2017
@kluever kluever self-assigned this Aug 13, 2017
@kluever kluever self-requested a review August 13, 2017 16:47
@cpovirk
Copy link
Member

cpovirk commented Aug 14, 2017

javac9 -Xdoclint rejects this version :(

It sounds like what we have is supposed to work (or at least ImmutableTable.Builder#Builder, perhaps?), but javadoc8 doesn't understand it. Oddly, it looks like javadoc9 doesn't understand it, either.... Maybe I'm doing something wrong.

@cpovirk
Copy link
Member

cpovirk commented Aug 14, 2017

Hmm, no, I was doing something wrong, though I'm not 100% sure what it was :) I'll see if I can at least get it to work with javadoc9 now.

@cpovirk
Copy link
Member

cpovirk commented Aug 14, 2017

OK, the code that we currently have in Github works under javadoc9. We can't switch to the new code without breaking our internal builds (which use java9 with -Xdoclint) -- and, it appears, breaking javadoc9. The easiest solution here is probably to wait for our switch to using Java 9 for our open-source builds.

@hawjo06
Copy link
Author

hawjo06 commented Aug 14, 2017

@cpovirk Thanks for looking into this, and the detailed responses. I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants